Coloring of non damage types and class names for skills

[elmodor]

Hey there,

first of, thank you for writing this tool! Love to see more open source tools.

You will probably close this MR anyway, since you wanted to keep this tool small and simple.

I wanted to have some more coloring, for these non damage "misc" types similar to rainbow. Furthermore having the class name for the skills also helps out a lot (maybe if you are a veteran you know all the skills but I do not).

So I added both, configurable with a flag. It's not really clean yet (like rewriting the class names text in the colorizer is just wrong) but I can change this if you would be open to merge this. The class name is obtained from the corresponding tag, so it should work for different languages too.

It will look like this ingame (I am really not sure about this dark green, never was, but there aren't many other colors left ...):

(Health in white, DA/Crit/All Skills in dark-green and class names)

(Though the class names are added to every skill, so also to the skills in the skill bar, skill window, devotions. Not quite sure if this can be prevent, since they all seem to be using the same tag)

If you want to keep this tool simple I can fully understand this too. Just wanted to share in case it is of interested.

[chrismac39]

@elmodor Love your ideas about extending the color palettes. It's hard to make them all work given the in-game limitations of the dark backgrounds in-game and the limited choices in the engine. I shamelessly copied your concept a bit and incorporated it into my fork with an additional option for users to create & edit their own color palette for gdse to use.

Would be more than happy to combine/collaborate if you are interested.

https://github.com/chrismac39/gdse/tree/feat/readme-and-version-tracking

[elmodor]

Well as I said, this was more meant as a draft because there is still stuff to do (as mentioned above, having the text changes in the colorizer is the wrong architecture).

I also think it would be nice if the text_class function would be more generic, matching tagSkillClassNameXX (and only XX, not XXXX (those are the class combination names)) and assign this to ClassXXSkill, so it supports theoretical additional classes.

Since this generates the tags, it might work nicely for mods too. Though CLASSES and obviously the db loading of the arz files would need to be adjusted. Not sure how tags work together with mods anyway, haven't used any class mods yet.

But yeah the idea of a color config profile is nice!