Support ArraysOfArrays v1 - #74
Open
oschulz wants to merge 1 commit into
Open
Conversation
Widen the ArraysOfArrays compat entry to "0.6, 1" and stop importing the private helper `front_tuple`, which ArraysOfArrays v1 renamed: the only use, the inner size of a `ConsecutiveParamArray`, is `Base.front` of the data size, since the data always has one more dimension than the inner arrays. This makes the code work with ArraysOfArrays 0.6 and 1 alike. Created by generative AI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArraysOfArrays.jl had a breaking release, I let Claude Code prepare dependency-updates for downstream packages, this is one of them:
This supersedes the CompatHelper PR #73. That PR widens the compat entry alone, and its CI fails with
because
front_tuplewas an unexported internal helper of ArraysOfArrays, and v1 renamed it to_front_tuple. Neither name exists in both majors, so the import has to go rather than be renamed.Closes #73
The change
Besides the compat bump to
"0.6, 1", two lines:This was the only use of
front_tuplein the repo. AConsecutiveParamArray{T,N}stores its data as anM = N+1-dimensional array, so taking the firstNentries of the data size is exactlyBase.frontof it — the two expressions agree by construction, andBase.frontworks on every supported Julia version, so the result is compatible with ArraysOfArrays 0.6 and 1 alike.Verification
I ran
test/FEM/param_data_structures.jlfrom the committed branch in fresh--depwarn=yessessions against both majors:Test Summary: param data structures | Pass 169 | Total 169— passedTest Summary: param data structures | Pass 169 | Total 169— passedNo deprecation or undefined-binding warnings in either configuration. I also spot-checked
innersize,innerlength,inneraxesand the_ncolonsindexing paths onConsecutiveParamVector/ConsecutiveParamMatrixdirectly, with identical results on both versions. I did not run the full suite — the Gridap stack is heavy — so I've left that to your CI.One note, and a small request
_ncolonsis likewise an ArraysOfArrays internal. It does still exist in v1, so nothing is broken and this PR leaves it alone — but it is a one-liner (_ncolons(::Val{N}) where N = ntuple(_ -> Colon(), Val{N}())), and defining it locally would remove GridapROMs' last coupling to ArraysOfArrays internals and rule out this class of breakage in future. Happy to add that here if you'd like it.If this looks good to you, would you be willing to tag a patch release once it's merged? The registry resolves compat from released versions, so without a tag GridapROMs would still hold its users back to ArraysOfArrays 0.6. Happy to answer any questions about the v1 changes if something comes up.
🤖 Generated with Claude Code