IGNITE-11346: Remote client authentication failed for the CommandHand…#123
Open
Maxoid wants to merge 3 commits intogridgain:masterfrom
Maxoid:feature/IGNITE-11346
Open
IGNITE-11346: Remote client authentication failed for the CommandHand…#123Maxoid wants to merge 3 commits intogridgain:masterfrom Maxoid:feature/IGNITE-11346
Maxoid wants to merge 3 commits intogridgain:masterfrom
Maxoid:feature/IGNITE-11346
Conversation
…ler in the case where it optional on the server
ibessonov
reviewed
Apr 10, 2019
|
|
||
| GridNioFuture<?> sndFut = ses.send(msg); | ||
| GridNioFuture<?> sndFut; | ||
| if(sesTok == null && credentials() != null ) { |
There was a problem hiding this comment.
Please reformat code according to codestyle.
ibessonov
reviewed
Apr 10, 2019
| req.requestId(reqId); | ||
|
|
||
| sndFut = ses.send(req); | ||
| } else { |
There was a problem hiding this comment.
Please reformat code according to codestyle.
ibessonov
reviewed
Apr 10, 2019
|
|
||
| req.requestId(reqId); | ||
|
|
||
| sndFut = ses.send(req); |
There was a problem hiding this comment.
I don't see where you send "msg" in this branch. Is it ignored?
Author
There was a problem hiding this comment.
The message is already pended in the original future (for which status is changing to STATE_AUTH_RETRY). So the message is not ignored but postponed.
…ler in the case where it optional on the server Unit test added
…ler in the case where it optional on the server style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-11346