Implemented Member ID support unique to server or driver. #3
Open
rdiyewar wants to merge 1 commit intogridgain:masterfrom
Open
Implemented Member ID support unique to server or driver. #3rdiyewar wants to merge 1 commit intogridgain:masterfrom
rdiyewar wants to merge 1 commit intogridgain:masterfrom
Conversation
… Drivers) can now be distinguish between themselves using this MemberID.
Contributor
|
Hi, Thank you for your contribution! Looks like it can be useful. Do you run your servers/drivers on the same or different hosts? If on different then you can use hostname as an id. We will do more detailed review in a couple days. |
Author
|
I had ran them on localhost, but my plan are to run actual benchmark on different hosts. Anyways I don't want to use hostname inside code and make it host specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing yardstick support for my product, i wanted to distiguish between servers and wanted to implement one out of many server in a specific way, however i could not find any way to do this.
Thus i added MemberID for each member in yardstick which is unique to Servers (Or Drivers). They can now be distinguish between themselves using this MemberID.
Added print statement in Server
Configuring server id=and DriverConfiguring driver id=inside EchoBenchmark example and found following output