Skip to content

Introduce the recently added artifacts Disenchantment in Deep Shadow#561

Open
gridhead wants to merge 1 commit into
mainfrom
dids
Open

Introduce the recently added artifacts Disenchantment in Deep Shadow#561
gridhead wants to merge 1 commit into
mainfrom
dids

Conversation

@gridhead
Copy link
Copy Markdown
Owner

@gridhead gridhead commented Jun 6, 2026

Introduce the recently added artifacts Disenchantment in Deep Shadow

Fixes #555

@gridhead gridhead added this to the Luna VII milestone Jun 6, 2026
@gridhead gridhead requested a review from sdglitched June 6, 2026 03:08
@gridhead gridhead self-assigned this Jun 6, 2026
@gridhead gridhead added the enhancement New feature or request label Jun 6, 2026
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @gridhead, your pull request is larger than the review limit of 150000 diff characters

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the "Disenchantment in Deep Shadow" artifact set, adding its asset paths, data definitions, and corresponding test cases. The review feedback points out a missing trailing newline at the end of the newly created gi_loadouts/data/arti/dids.py file, which violates PEP 8 guidelines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread gi_loadouts/data/arti/dids.py Outdated


class ccol(team, CCOL):
__name__ = "Pendulum That Ceased Amidst a Great Fall" No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file is missing a newline at the end. According to PEP 8 (W292), all source files should end with a single trailing newline.

Suggested change
__name__ = "Pendulum That Ceased Amidst a Great Fall"
__name__ = "Pendulum That Ceased Amidst a Great Fall"
References
  1. PEP 8: W292 no newline at end of file. (link)

Co-authored-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Co-authored-by: Claude Code <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the recently added artifact set Disenchantment in Deep Shadow to the GI Loadouts roster

1 participant