fix(cluster): poll after up --profile instead of claiming Active#72
Merged
Conversation
forge no longer provisions on the request path: `POST /v1/cluster/up` enqueues and a background worker reconciles, so the response now carries state=creating. The legacy --profile path printed "Workspace Active" and exited the moment the request returned, which would have reported success while the vCluster was still being built — and said nothing at all when the provision later failed. Reuse waitForBundle (a generic GET /v1/cluster poller, already used by the default bundle path) and exit non-zero on a failed provision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXYNq1wXz2hFg4yzPsHdDx
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client-side follow-up to groundsgg/grounds-forge#439. Merge that first.
Why
forge no longer provisions on the request path —
POST /v1/cluster/upnow enqueues and a background worker reconciles (this is what lets the internet-facing forge api pod drop the cluster-wide RBAC that currently lets it escalate tocluster-admin). So the response comes backstate=creating, notactive.The legacy
--profilepath printed "Workspace Active" and exited the moment the request returned. Post-change that would report success while the vCluster is still building — and stay silent if the provision later failed.What
Reuse
waitForBundle, the genericGET /v1/clusterpoller the default bundle path already uses, and exit non-zero when the workspace endsfailed.The default (bundle) path already polled and is unchanged.
ClusterUpneeded no change —doRequestalready accepts any status < 400.Verification
go build+go vet+ package tests pass.waitForBundleis directly covered by existing tests;BundleProgressSummary(nil)returns"", so the minigame/platform profiles (which carry nobundleProgress) fall through to the plainstate:line rather than nil-dereferencing.🤖 Generated with Claude Code
https://claude.ai/code/session_01AXYNq1wXz2hFg4yzPsHdDx