feat(ci): publish the plugin image to ghcr#9
Closed
hbrombeer wants to merge 1 commit into
Closed
Conversation
plugin-proxy has never shipped an artifact: no image, no maven release. plugin-chat declares a hard Velocity dependency on it (and resolves ProxyServiceRegistry from its classes at runtime), so neither can be deployed until this one is pullable. Add the standard docker-gradle-build-push workflow (edge on main, semver on tag) and a Dockerfile carrying the shaded JAR at /jar/plugin.jar — the shape the plugin-velocity-jar chart expects. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E92vTegZqXd2HqjE7jnDJz
Member
Author
|
Not needed after all: plugin-chat on main no longer depends on plugin-proxy (it carries its own NATS PlayerRegistry), so chat can ship without it. Reopen if plugin-proxy should be deployed in its own right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin-proxy has never shipped: no image, no tag, no maven artifact. It is a hard dependency of plugin-chat (
@Plugin(dependencies = [Dependency(id = "plugin-proxy")]), and chat resolvesProxyServiceRegistryfrom plugin-proxy's classes at runtime), so chat cannot be deployed to a workspace until this is pullable.Adds the standard
docker-gradle-build-pushworkflow (edge on main, semver on tag) plus a Dockerfile that carries the shaded velocity JAR at/jar/plugin.jar— the shape theplugin-velocity-jarHelm chart expects.Verified with a local
docker build --secret id=github_token …: the image carries the 8 MB shaded JAR andProxyServiceRegistryis in it.Follow-up: the library-platform-bundle adds
plugin-proxy+plugin-chatas velocity plugin components.🤖 Generated with Claude Code
https://claude.ai/code/session_01E92vTegZqXd2HqjE7jnDJz