Repository navigation
fix: bump advanced-security/component-detection-dependency-submission-action from 0.1.6 to 0.2.0 - #2397
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Dependency Review SummaryThe full dependency review summary was too large to display here (13010KB, limit is 1024KB). Please download the artifact named "dependency-review-summary" to view the complete report. |
groupthinking
left a comment
There was a problem hiding this comment.
Review at head 43fc8eeb: dependency-review fails on this GitHub Action update. Please inspect the flagged dependency result, resolve the incompatibility or document a justified exception, and rerun the exact-head check before approval.
…-action Bumps [advanced-security/component-detection-dependency-submission-action](https://github.com/advanced-security/component-detection-dependency-submission-action) from 0.1.6 to 0.2.0. - [Release notes](https://github.com/advanced-security/component-detection-dependency-submission-action/releases) - [Commits](advanced-security/component-detection-dependency-submission-action@b282c67...a02aeda) --- updated-dependencies: - dependency-name: advanced-security/component-detection-dependency-submission-action dependency-version: 0.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
43fc8ee to
f5b4d06
Compare
groupthinking
left a comment
There was a problem hiding this comment.
Code review at exact head cf6d2ec62a55abeecbd8ba17381fdf517a4a1f38: the effective diff only advances the three pinned component-detection submission action references to the verified v0.2.0 tag SHA. The upstream v0.2.0 source builds dependency packages and scope per manifest, addressing the older version’s cross-manifest scope-mapping risk seen with fast-uri; 20 focused workflow tests and the current hosted code checks pass. This approval covers that narrow action update and supersedes my earlier generic requested-changes review on the old head. It does not approve a dependency verdict or a merge: the exact-head dependency-review run still warns about 3 base versus 1 head snapshot, then exceeds GitHub’s output-expression limit and uploads no evidence artifact. The separate v0.2.0 canary #2494 also failed snapshot parity. Keep #2397 open and unmerged until the shared workflow produces complete, semantically checked evidence on the final head.
## Current status — approved exact-head repair Head `85f1815ddb7ec121680d067d165e18eb40d90eda` targets `main` at merge commit `e010c9f3cec5ae72be16814d0841578ea9f8ded2`, after [#2487](#2487) merged at exact head `148cbf55fdce412255d2a61780459143521fa4c4`. The verified merge commit has the same tree as that head, so this PR's seven-file diff is unchanged. It adds complete npm lockfile coverage, preserves the scoped `uv.lock` classification, and combines both lock types into one manual snapshot so GitHub's pinned review action can compare the full base and head graphs. The controlled [#2501](#2501) test passed on an exact four-file dependency update. This has **not** yet produced a passing dependency comparison against the current `main` or cleared the original review queue. The exact-head [dependency review run 40760369080](https://github.com/groupthinking/EventRelay/actions/runs/40760369080) succeeded through its **code-only no-delta** path: the full-tree and combined lock submissions were correctly skipped because this PR changes workflow code and tests, not dependency inputs. Before the automatic base retarget, all 30 hosted checks at this same code head finished: **27 successful, 3 skipped, zero failed or pending**. The retarget did not run a new dependency comparison. A green no-delta check does not substitute for the controlled #2501 dependency test or a postmerge real PR test. A description-only edit may rerun metadata checks. ## Canonical issue Fixes #2505 on merge under the repository's issue-link rule. Parent #2490 stays open until a repaired `main` snapshot and a refreshed real dependency PR pass the full comparison. #2487 merged at the approved head, and GitHub automatically retargeted this draft to `main` at `e010c9f3cec5ae72be16814d0841578ea9f8ded2`. The head and seven-file diff remain unchanged. Hayden approved marking this exact head ready and merging it. Main-based dependency comparison remains a required postmerge verification. ## Changes - Remove focused one-ecosystem snapshot staging from `.github/workflows/dependency-review.yml`. Submit the same full-tree component-detection scan on `main` pushes and same-repository dependency PR heads at the exact commit SHA and ref. Keep the verified upstream component-detection v0.2.0 pin from #2397 and the existing severity, license and advisory policy. - Treat Dependabot configuration changes as configuration, and compare a PR head to its merge base when detecting new dependency inputs. A stale branch cannot turn a change made only on `main` into a dependency update in that PR. Real changed manifests and locks remain subject to review. - Include **every distinct name/version** from the tracked npm lockfiles, including nested second versions that component detection can omit. Group duplicate installed paths with runtime scope if any path is runtime. Submit those npm manifests and the scoped root `uv.lock` manifest in **one** manual snapshot after the full-tree scan. The scoped uv manifest treats packages reached only through `dev` or `docs` as development. The evidence recorder rejects missing, extra, wrong-manifest, wrong-version or wrong-scope rows against the exact changed lockfiles. - Increase the bounded per-file Python `PipReport` scan from 120 to 240 seconds and the job window to 30 minutes after an observed timeout produced unrelated requirements-file removals. A timeout still falls back to declared dependencies and can omit transitive packages; the guard rejects unrelated graph drift. Keep the 600-second snapshot-warning retry and warning rejection. - Add regression coverage for workflow selection, stale branches, npm nested versions and duplicate scope, combined one-request submission, scoped uv reachability, and exact evidence validation. ## Changed paths - `.github/workflows/dependency-review.yml` - `scripts/ci/record_dependency_review.py` - `scripts/ci/submit_npm_lock_snapshot.py` - `scripts/ci/submit_uv_lock_snapshot.py` - `tests/unit/test_dependency_review_workflow.py` - `tests/unit/test_submit_npm_lock_snapshot.py` - `tests/unit/test_submit_uv_lock_snapshot.py` ## Validation - Focused workflow, recorder, npm and uv snapshot suite: `uv run --no-project --with pytest --with pyyaml python -m pytest -q -o addopts='' tests/unit/test_submit_npm_lock_snapshot.py tests/unit/test_submit_uv_lock_snapshot.py tests/unit/test_dependency_review_workflow.py` — **31 passed in 3.10s** at the source head. `uv run --no-project --with ruff ruff check` and `ruff format --check` on those affected Python files, plus `git diff --check`, passed. - Controlled uv [#2499](#2499) used the exact `uv.lock` delta from original #2486 on matching off-main branches. Final [hosted run 40738274345, attempt 2](https://github.com/groupthinking/EventRelay/actions/runs/40738274345) passed policy, recorder and upload with **65 exact rows** (34 additions, 31 removals), correct package names, versions, manifests and development scopes, and no reported vulnerabilities. `ddtrace-internal` had unknown license metadata. The first attempt raced the base snapshot; the unchanged rerun passed. #2499 was closed unmerged. - Earlier controlled [#2500](#2500) used original #2355's exact two npm lockfile changes and exposed a **10/12 coverage gap** in component detection: nested development `brace-expansion` 2.1.4→2.1.7 was missing. Independent local npm audits of both lockfiles found no new advisory and fewer findings after the update (fetch 18→14; SDK 10→9). That green hosted check was insufficient; #2500 was closed unmerged. - Final controlled [#2501](#2501) used the exact four-file #2355 patch between base `eb6e556ef9eb8df80250613291c73abfb59b9f0e` and head `050f211b9715918f52c488a912d3ae797e76d68e`. [Base run 40759330706](https://github.com/groupthinking/EventRelay/actions/runs/40759330706) submitted the full-tree and combined lock snapshots; [head run 40759346059](https://github.com/groupthinking/EventRelay/actions/runs/40759346059) passed policy, recorder and upload. Its artifact and independent GitHub comparison contain **all 12 exact lock changes**, only from the two changed npm locks, with the nested `brace-expansion` row, correct scopes, zero added vulnerabilities, and added licenses MIT or BSD-3-Clause. GitHub's comparison with the review action's `per_page=5` request is also warning free. #2501 was closed unmerged; its temporary refs were deleted. - The final #2501 success followed two diagnosed issues: an unchanged Python requirements file generated 83 false removals after a 120-second fallback, and the pinned review action's five-item API page returned a **0-base/3-head** warning when full-tree, uv and npm were submitted separately (six snapshots across both sides). The same comparison with a larger page was warning free and had the correct 12 rows. Combining uv and npm manifests leaves two submissions per side and yielded the passing hosted result. Earlier #2493–#2496 diagnostics documented the initial main snapshot mismatch, the upstream manifest mapping update and scope validation; those results remain historical evidence, not a main-based pass. ## Remaining gates - [x] #2487 merged at its approved head; this draft automatically retargeted to `main`, and its unchanged seven-file diff was reviewed. - [x] Complete npm lock coverage and correct uv scope demonstrated in controlled hosted canaries, with the five-item review comparison warning free on #2501. - [x] Exact-head #2492 code-only dependency check and other hosted checks passed or skipped before the base retarget (27 successful, 3 skipped). This does not prove a main-based dependency update comparison. - [x] Hayden approved marking exact head `85f1815ddb7ec121680d067d165e18eb40d90eda` ready and merging #2492 after review of the main snapshot uncertainty. - [ ] After the merge, confirm the new `main` full-tree and combined lock submission, refresh one original manifest-changing PR onto that main, and require a warning-free hosted policy verdict plus complete artifact matching its actual dependency files. Then refresh and recheck the remaining original dependency PRs. Do not claim the original 21 dependency failures are resolved until this passes. - [ ] Resolve any outstanding review findings and merge decisions for the original PRs independently of this shared repair.
|
Closing as superseded. This PR only changes three references to |
Review update — 2026-10-28
Current head
cf6d2ec62a55abeecbd8ba17381fdf517a4a1f38merges currentmain(ba2777d1b008c2148d413e07cc497791966310e0). Its effective diff changes only the three pinnedadvanced-security/component-detection-dependency-submission-actionreferences in.github/workflows/dependency-review.ymlfrom v0.1.6 to the verified v0.2.0 tag SHAa02aeda7a175ad4dd38a13c4d3ff2df9da8f2cf0. All 20 focused workflow tests andgit diff --checkpassed. Hosted checks finished 25 passed, 3 skipped, 1 failed. The remainingdependency-reviewfailure is the pre-existing evidence expression exceeding GitHub's template memory limit; no evidence artifact was uploaded. That fix is pending in #2487.The upstream v0.2.0 release includes a manifest-mapping fix, but the real fast-uri diagnostic #2494 still encountered 3 base versus 1 head snapshots and a misleading diff with 1,347 temporary-path removals. #2494 closed unmerged; the underlying snapshot parity issue remains open as #2490. This PR is open for review, not established as the parity fix or ready to merge. The original Dependabot release notes follow.
Original Dependabot notes
Bumps advanced-security/component-detection-dependency-submission-action from 0.1.6 to 0.2.0.
Release notes
Sourced from advanced-security/component-detection-dependency-submission-action's releases.
Commits
a02aedachore: bump version (minor) (#256)2b3feceMerge main into deps/fail-on-empty and rebuild dist (#255)ac3bac2Bump pinned undici to 6.28.1 (GHSA-rfgv-xxqx-mfg5) (#254)b256103chore(deps): bump the npm-dependencies group across 1 directory with 6 update...0fa5d39Fix dependency snapshot manifest generation (#249)ce792dcchore(deps): bump the npm-dependencies group across 1 directory with 4 update...2dfcd4cchore(deps): bump advanced-security/reusable-workflows/.github/workflows/rele...