Repository navigation
feat: persist confirmed workflow tasks with owner-scoped retries - #2472
Draft
groupthinking wants to merge 1 commit into
Draft
groupthinking wants to merge 1 commit into
groupthinking wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2473 (software implementation only; live acceptance remains unverified).
create_workflow_taskcurrently reports “Created task” without saving anything. This change writes confirmed tasks through the existing Upstash REST configuration, requires session-derived provider/subject identity and a run ID, and verifies readback before reporting fulfillment. Atomic SET NX gives identical retries the same record and ID. Owner-scoped GET readback and task receipt serialization are included; preview remains read-only.Implemented at
b2c935ee0df5af909ba03de009bcac0a99ef6b29against maine93fd0e975cda0f3a59cb7fa812c19c64f6b2a52.Validation: 42 focused tests passed; full web suite 1,530 passed / 28 skipped across 171 files before the final provider/subject identity tightening, then all 42 focused tests passed again. Type-check, changed-file ESLint and diff whitespace checks passed. Tests use an isolated REST fixture: one confirmation plus three concurrent retries produces one record and the same receipt. See WORKFLOW_TASK_IMPLEMENTATION.md for commands, boundaries and remaining acceptance criteria.
This is implementation evidence only. Live Upstash fresh-process readback, verified video source timestamps/hash, authenticated UI acceptance, provider usage/cost and a real end-to-end receipt remain unverified. No merge or production activation is requested. Task writes now require sign-in and a run ID; missing storage fails closed without an in-memory fallback. Existing task records have no TTL. Revert this commit to roll back the code (reverting does not remove stored records).
Related #2470 is a local review-only journal, not this hosted task adapter. Both touch the actions route and need integration review. Hayden authorized this bounded cut by asking to start the Oct 23 status report's recommended next action.