Skip to content

compiler: add retry loop and enable allowEmptyChecksums on Windows #12962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kannanjgithub wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compiler: add retry loop and enable allowEmptyChecksums on Windows #12962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions buildscripts/make_dependencies.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
choco feature enable -n allowEmptyChecksums

@shivaspeaks shivaspeaks Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this modifies the global Chocolatey state, do we need to disable it (choco feature disable -n allowEmptyChecksums) after the installation finishes? Or is it safe to leave it permanently enabled?


set RETRY=0
:install_pkgconfig
choco install -y pkgconfiglite --allow-empty-checksums

@shivaspeaks shivaspeaks Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--allow-empty-checksums this flag becomes redundant because it is enabled globally?

if %ERRORLEVEL% neq 0 (
if %RETRY% lss 3 (
set /a RETRY=%RETRY%+1
echo pkgconfiglite installation failed. Retrying %RETRY% of 3 in 5 seconds...
@rem Sleep for 5 seconds using the loopback ping trick (timeout command fails in non-interactive CI)
ping -n 6 127.0.0.1 >nul
goto :install_pkgconfig
)
echo Failed to install pkgconfiglite after 3 attempts.

@shivaspeaks shivaspeaks Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either loop 2 times for this statement to hold true. Or we can say here-
echo Failed to install pkgconfiglite after 4 attempts.

exit /b 1
)

choco install -y openjdk --version=17.0
set PATH=%PATH%;"c:\Program Files\OpenJDK\jdk-17\bin"
set PROTOBUF_VER=35.1
Expand Down
Loading