finish removing Python2 support#178
Open
a-detiste wants to merge 2 commits into
Open
Conversation
Author
|
@gruns Hi, I was surprised to see this PR not included. There's no a hurry either. |
Owner
|
hey @a-detiste! first? a huge thank you for your PR! sincerely 🙏
@alexcochran do you have bandwidth to review and merge this PR? 🙌 |
alexcochran
added
the
Update/Dependencies
alexcochran
reviewed
Apr 16, 2026
Collaborator
alexcochran
left a comment
alexcochran
left a comment
There was a problem hiding this comment.
This looks good in general but causes several more tests to fail in addition to those already failing on master:
======================================================================= short test summary info ========================================================================
FAILED tests/test_furl.py::TestPath::test_isabsolute - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_basic_manipulation - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_basics - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_hosts - ValueError: '0:0:0:0:0:0:0:1:1:1:1:1:1:1:1:9999999999999' does not appear to be an IPv4 or IPv6 address
FAILED tests/test_furl.py::TestFurl::test_join - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_netloc - ValueError: '0:0:0:0:0:0:0:1:1:1:1:1:1:1:1:9999999999999' does not appear to be an IPv4 or IPv6 address
FAILED tests/test_furl.py::TestFurl::test_none - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_odd_urls - AssertionError: assert '//////path' == '////path'
FAILED tests/test_furl.py::TestFurl::test_path_itruediv - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_path_truediv - TypeError: __str__ returned non-string (type bytes)
FAILED tests/test_furl.py::TestFurl::test_remove - TypeError: __str__ returned non-string (type bytes)
==================================================================== 11 failed, 66 passed in 5.05s =====================================================================
I can look into this more later.
Author
|
It's down to 3 failures now |
Author
|
past myself is not really helpfull https://sources.debian.org/src/python-furl/2.1.4-0.1/debian/patches/enable_tests.patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here's what you need to finish removing Python2 hybridation.
https://wiki.debian.org/Python3-six-removal
Greetings