Upstream sync for libfstwriter (refactored for Verilator)#6
Merged
rfuest merged 3 commits intogtkwave:mainfrom Apr 22, 2026
Merged
Upstream sync for libfstwriter (refactored for Verilator)#6rfuest merged 3 commits intogtkwave:mainfrom
rfuest merged 3 commits intogtkwave:mainfrom
Conversation
- Remove inline functions defined+declared in class (it is inlined by spec)
- Add MSC_VER_ macro
- Change "and or not" to "&& || !!"
- exception -> abort
- Remove using namespace std
- Reduce abuse of auto
- Use {} style constructor calls/initialization
- Remove TODO API.
rfuest
approved these changes
Apr 22, 2026
Contributor
rfuest
left a comment
rfuest
left a comment
There was a problem hiding this comment.
I did take a quick look at the PR and couldn't find any obvious issues. I trust the review from the Verilator PR and will merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @rfuest,
I’m currently integrating libfstwriter into Verilator (verilator/verilator#6992). To meet their requirements, I’ve performed a substantial refactor to align the code with Verilator style.
The changes have already been thoroughly reviewed by @gezalore. Since libfstwriter is hosted here under GTKWave, hw wants to merge these updates back to ensure this repository remains the "source of truth" and avoid long-term code divergence.
I understand this PR is large; please let me know if you need more context on specific parts of the implementation.
Best regards,
Yu-Sheng Lin