Add header to match info page #15229
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
changed the base branch from
main
to
wire-up-the-new-match-info-page
marjisound
force-pushed
the
add-header-to-match-info-page
branch
from
4867d8c to
3345907
Compare
marjisound
commented
Jan 28, 2026
| paId: string; | ||
| kickOff: Date; | ||
| venue: string; | ||
| venue?: string; |
Contributor
Author
There was a problem hiding this comment.
This field is optional from frontend, and although we expect it always to be avaiable, I don't think we should avoid rendering the page if it doesn't exist
marjisound
force-pushed
the
add-header-to-match-info-page
branch
from
3345907 to
20eb171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds the new football header to the new Match Info page.
Screenshots
This fixes part of #15219