Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ab-testing/config/abTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,6 @@ const ABTests: ABTest[] = [
groups: ["control", "variant"],
shouldForceMetricsCollection: true,
},
{
name: "fronts-and-curation-onward-journeys",
description: "Testing the new Onward Journey component on all articles",
owners: ["fronts.and.curation@guardian.co.uk"],
expirationDate: `2026-02-25`,
type: "client",
status: "ON",
audienceSize: 50 / 100,
audienceSpace: "A",
groups: ["control", "variant"],
shouldForceMetricsCollection: false,
},
{
name: "fronts-and-curation-personalised-container",
description: "Testing the a personalised container component on fronts",
Expand Down
10 changes: 1 addition & 9 deletions dotcom-rendering/src/components/Card/Card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ export type Props = {
headlinePosition?: 'inner' | 'outer';
isStorylines?: boolean;
starRatingSize?: RatingSizeType;
isInOnwardsAbTestVariant?: boolean;
isInPersonalisationVariant?: boolean;
};

Expand Down Expand Up @@ -407,7 +406,6 @@ export const Card = ({
subtitleSize = 'small',
isStorylines = false,
starRatingSize = 'small',
isInOnwardsAbTestVariant,
isInPersonalisationVariant,
}: Props) => {
const hasSublinks = supportingContent && supportingContent.length > 0;
Expand Down Expand Up @@ -681,12 +679,7 @@ export const Card = ({
*/
const getGapSizes = (): GapSizes => {
if (isOnwardContent && !isGallerySecondaryOnward) {
if (
isMoreGalleriesOnwardContent ||
// This is untidy. If we implement the gallery-style redesign for onwards content
// in all articles, we can refactor how we determine gap sizes for onwards cards.
isInOnwardsAbTestVariant
) {
if (isMoreGalleriesOnwardContent) {
return {
row: 'small',
column: 'small',
Expand Down Expand Up @@ -1241,7 +1234,6 @@ export const Card = ({
isBetaContainer,
isOnwardContent,
)}
isInOnwardsAbTestVariant={!!isInOnwardsAbTestVariant}
>
{/* In the storylines section on tag pages, the flex splash is used to display key stories.
We don't display an article headline in the conventional sense, the key stories are instead displayed as "supporting content".
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ type Props = {
isBetaContainer: boolean;
mediaPositionOnDesktop: MediaPositionType;
mediaPositionOnMobile: MediaPositionType;
isInOnwardsAbTestVariant: boolean;
padContent?: 'small' | 'large';
};

Expand All @@ -160,7 +159,6 @@ export const ContentWrapper = ({
isBetaContainer,
mediaPositionOnDesktop,
mediaPositionOnMobile,
isInOnwardsAbTestVariant,
padContent,
}: Props) => {
const mediaDirectionDesktop = getMediaDirection(mediaPositionOnDesktop);
Expand All @@ -178,7 +176,6 @@ export const ContentWrapper = ({
}),
padContent &&
!isBetaContainer &&
!isInOnwardsAbTestVariant &&
css`
padding: ${space[paddingSpace]}px;
`,
Expand Down
13 changes: 0 additions & 13 deletions dotcom-rendering/src/components/FetchOnwardsData.importable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import type { OnwardsSource } from '../types/onwards';
import type { RenderingTarget } from '../types/renderingTarget';
import type { FETrailType, TrailType } from '../types/trails';
import { Carousel } from './Carousel.importable';
import { MoreGalleriesStyleOnwardsContent } from './MoreGalleriesStyleOnwardsContent.importable';
import { Placeholder } from './Placeholder';
import { ScrollableSmallOnwards } from './ScrollableSmallOnwards';

Expand All @@ -32,7 +31,6 @@ type Props = {
renderingTarget: RenderingTarget;
isAdFreeUser: boolean;
containerPosition: string;
isInOnwardsAbTestVariant?: boolean;
webURL: string;
};

Expand Down Expand Up @@ -82,7 +80,6 @@ export const FetchOnwardsData = ({
renderingTarget,
isAdFreeUser,
containerPosition,
isInOnwardsAbTestVariant,
webURL,
}: Props) => {
const [hasBeenSeen, setIsInViewRef] = useIsInView({ rootMargin: `-100px` });
Expand Down Expand Up @@ -165,16 +162,6 @@ export const FetchOnwardsData = ({
onwardsSource={onwardsSource}
format={format}
/>
) : isInOnwardsAbTestVariant ? (
<MoreGalleriesStyleOnwardsContent
heading={data.heading || data.displayname}
trails={trails({
withMasterImage: true,
permitFallbackImage: true,
})}
discussionApiUrl={discussionApiUrl}
isAdFreeUser={isAdFreeUser}
/>
) : (
<Carousel
heading={data.heading || data.displayname} // Sometimes the api returns heading as 'displayName'
Expand Down

This file was deleted.

10 changes: 0 additions & 10 deletions dotcom-rendering/src/components/OnwardsUpper.importable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
Pillar,
} from '../lib/articleFormat';
import type { EditionId } from '../lib/edition';
import { useBetaAB } from '../lib/useAB';
import { useIsHorizontalScrollingSupported } from '../lib/useIsHorizontalScrollingSupported';
import { palette } from '../palette';
import type { OnwardsSource } from '../types/onwards';
Expand Down Expand Up @@ -225,14 +224,6 @@ export const OnwardsUpper = ({
renderingTarget,
webURL,
}: Props) => {
const abTests = useBetaAB();
const isInOnwardsAbTestVariant =
renderingTarget === 'Web' &&
abTests?.isUserInTestGroup(
'fronts-and-curation-onward-journeys',
'variant',
);

const isHorizontalScrollingSupported = useIsHorizontalScrollingSupported();
if (!isHorizontalScrollingSupported) return null;

Expand Down Expand Up @@ -347,7 +338,6 @@ export const OnwardsUpper = ({
renderingTarget={renderingTarget}
isAdFreeUser={isAdFreeUser}
containerPosition="first"
isInOnwardsAbTestVariant={isInOnwardsAbTestVariant}
webURL={webURL}
/>
</Section>
Expand Down
Loading