Skip to content

fix: Only capture process.stdout.write when mute is called - #14

Merged
phated merged 10 commits into
gulpjs:mainfrom
FotoVerite:main
Oct 28, 2026
Merged

phated merged 10 commits into
gulpjs:mainfrom
FotoVerite:main

Conversation

@FotoVerite

@FotoVerite FotoVerite commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Closes #13
Closes #15

@phated phated left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pausing review until sinon is replaced.

Comment thread test/index.js Resolved
@phated phated added this to v6 Oct 19, 2026
@phated phated moved this to In Progress in v6 Oct 19, 2026
Comment thread test/index.js Resolved
@FotoVerite
FotoVerite requested review from phated and removed request for phated October 21, 2026 17:44
Comment thread test/index.js Resolved
Comment thread test/index.js Resolved
Comment thread test/index.js Resolved
Comment thread index.js Resolved
Comment thread test/index.js Resolved
@FotoVerite
FotoVerite requested a review from phated October 21, 2026 19:04
Comment thread test/index.js Resolved
Comment thread test/index.js Resolved
Comment thread test/index.js Resolved
Comment thread index.js Resolved
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Comment thread test/index.js Resolved
Comment thread test/index.js Resolved
@phated phated changed the title chore: Replace mocha/expect/nyc with node:test harness fix: Only capture process.stdout.write when mute is called Oct 28, 2026

@phated phated left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I resolved the outstanding stuff so we can land this

@phated
phated merged commit ef44f9c into gulpjs:main Oct 28, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in v6 Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implementation doesn't account for process.stdout.write being changed Update test harness

2 participants