Skip to content

Restore GAP device name after GATT reset #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chmorgan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restore GAP device name after GATT reset #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/NimBLEServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,8 +889,21 @@ bool NimBLEServer::resetGATT() {
NimBLEDevice::stopAdvertising();
# endif

Comment thread
chmorgan marked this conversation as resolved.
// esp-idf nimble clears the device name and
// appearance during ble_gatts_reset()
#ifndef CONFIG_USING_NIMBLE_COMPONENT
std::string name(ble_svc_gap_device_name());
uint16_t appearance = ble_svc_gap_device_appearance();
#endif

ble_gatts_reset();
ble_svc_gap_init();
Comment thread
chmorgan marked this conversation as resolved.

#ifndef CONFIG_USING_NIMBLE_COMPONENT
ble_svc_gap_device_name_set(name.c_str());
ble_svc_gap_device_appearance_set(appearance);
#endif

ble_svc_gatt_init();

for (auto svcIt = m_svcVec.begin(); svcIt != m_svcVec.end();) {
Expand Down