fix: distinguish -0.0 from 0.0 when caching pack_key#18
Merged
Conversation
test_increment_packed_key was failing because hypothesis generated an example with -0.0, 0.0 which failed because pack_key was caching -0.0 and 0.0 as being equivalent, so the (cached) packed representation of both was the same. pack_key() now distinguishes negative/positive zero float values when caching packed keys.
KvKey now implements __bytes__() to return the packed key value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_increment_packed_key was failing because hypothesis generated an
example with -0.0, 0.0 which failed because pack_key was caching -0.0
and 0.0 as being equivalent, so the (cached) packed representation of
both was the same.
pack_key() now distinguishes negative/positive zero float values when
caching packed keys.