Support closing Kv objects manually and automatically#20
Merged
Conversation
Kv now has a closed property, aclose() method and is an async context manager, to support auto-closing. (Previously the aiohttp session would need to be closed.)
The Kv.create_finalizer() method returns a finalizer that automatically closes the instance when it goes out of scope, or at exit. This allows for auto-cleanup of Kv instances in environments where it's awkward to use a context block, like an interactive REPL.
When running in Python REPLs, Kv instances now automatically close at exit. This avoids the aiohttp.ClientSession printing warnings about un-closed connections when exiting a REPL.
There are never going to be many instances at once, no point in using slots. (We need to support weakrefs of Kv, and using slots complicates this.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements support for closing
Kvclient via:Kv.aclose()Kv.create_finalizer()Kvobjects created byopen_kv()from an interactive console/REPL automatically close at exit.open_kv()function has afinalizeoption that controls this.