Avoid if TYPE_CHECKING: cruft by centralising typing compatibility#22
Merged
Avoid if TYPE_CHECKING: cruft by centralising typing compatibility#22
if TYPE_CHECKING: cruft by centralising typing compatibility#22Conversation
This allows us to import all type annotations/types/functions from here, rather than typing or typing_extensions, which lets us handle the differences between them in one place, without needing if TYPE_CHECKING everywhere.
h4l
force-pushed
the
unified-typing-compat
branch
from
5330161 to
89f6ad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the mess and toil of using
if TYPE_CHECKING:to import stuff fromtyping_extensions, we now export all the types we use from a singledenokv._pycompat.typingmodule. This allows the rest of the modules to ignore typing compat issues, and transparently use stuff fromtyping_extensionswhere needed (but without depending ontyping_extensions).