Repository navigation
fix: flush capability output before subprocess exit - #92
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.32.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability inventory could exit before large JSON output finished writing to a subprocess pipe. Consumers received a truncated document (reported at 65,536 bytes) instead of parseable inventory.
Await the existing stdout writer for capability results, digests, and help. Add a real OS-pipe regression that verifies more than 128 KiB of JSON, all entry IDs, and the complete final entry. Run the same assertion in the compiled-binary verifier on each CI platform. Bun subprocess sockets masked the failure, so the regression captures through Node child_process pipes.
Validation: the regression rejects the published 2.32.0 binary; the patched local binary passes. All 30 capability tests, lint, type checking, binary build/verifier, and package dry run pass. Full-suite results and exact-head CI are recorded separately.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.