[roodboi]

Problem

The gum-backed logger (src/ui/logger.ts → tryGumLog in src/ui/gum.ts, chosen by HACK_LOGGER or by detecting gum) passed the log message to gum as a bare argument. When a message started with - or --, gum's kong parser read it as a flag. It printed gum: error: unknown flag ... and the gum log usage to stderr, and then the logger fell back to clack. gum style and gum join had the same problem with dash-leading text.

Change

• Every gum call in src/ui/gum.ts that takes free text now puts it after --. This covers log messages and structured fields, style/join text, the confirm prompt, choose/filter options, the file path, pager content, format templates, the wrapped spin command and the version-check constraint.
• Flags that take a value (--header, --placeholder, --prompt, --value, --title, --affirmative, --negative, --cursor, delimiters, and the rest) are now passed as one token, --flag=value. In the two-token form kong rejects a value that starts with -.
• All gum calls now go through a small GumRunner boundary with a setGumRunnerForTests seam, so tests can check argv without gum installed. The real runner still uses Bun.spawn / Bun.spawnSync with the same stdio and env as before.
• tests/fixtures/gum now skips a leading -- for version-check.

How gum handles -- (checked with gum v0.17.0, the bundled version)

• gum log --level info -- "--value-stdin requires x" prints the message and exits 0. Without -- it prints the usage and unknown flag.
• style, join and format accept -- and print dash-leading text as-is. version-check -- '>=0.1' exits 0.
• spin --title=--weird -- true exits 0. In spin --show-output -- echo -- hi, gum removes the first -- and the wrapped command gets -- hi.
• confirm, choose, filter, input, write, pager and file, called with --flag=-value and -- -positional, all parse cleanly and stop only when they try to open the missing TTY. None printed a usage error.
• gum style --border-foreground -x hi (two-token form) prints the usage. --margin=-1 is accepted.

Validation

• New tests/gum-end-of-options.test.ts (12 tests) injects a recording runner and checks the argv for every call site, including logger.error/logger.success with the gum backend selected. It does not need gum installed and spawns no process.
• Mutation checks (each one breaks the code on purpose; every new test failed under at least one):
  • Removing the -- marker: 9 tests fail.
  • Going back to two-token flag values: 10 tests fail.
  • Negative control: the old tryGumLog argv, which puts --value-stdin requires --env before any marker, fails the 3 log/logger tests.
  • Moving style text, the confirm prompt, the spin command or choose options back before the flags: 1 test fails each time.
• Manual check against the real gum binary: on the old module, log, style and join print gum: error: unknown flag --value-stdin requires --env and return failure. On the new module, all three render the text and succeed, and format and version-check succeed too.
• bun test passes 129/129 across gum.test.ts, the new test file, output-hygiene, display, control-plane-extensions, project-up-startup-state, global-command, project-run-command, lifecycle-json, integration-ownership and agent-plugin-generation.
• bun run --cwd packages/cli typecheck passes. bun run --cwd packages/cli check reports 0 errors. Its warnings are existing ones and none are in the changed files.

Gaps

• The interactive commands (confirm, choose, filter, input, write, pager, file) were checked only up to argument parsing. No TTY session was run.
• The full bun run test suite and hosted CI have not run yet.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}