Skip to content

XY-855: Add independent fresh-context review orchestrator #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
Jun 9, 2026
Merged

XY-855: Add independent fresh-context review orchestrator #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions apps/decodex/src/agent/tracker_tool_bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,10 +776,61 @@ struct TerminalFinalizeArgs {
struct ReviewCheckpointArgs {
#[serde(flatten)]
scope: ScopeArgs,
reviewer: Option<String>,
status: String,
head_sha: String,
checks: Option<ReviewCheckpointChecksArgs>,
#[serde(default)]
evidence: Vec<String>,
#[serde(default)]
accepted_findings: Vec<ReviewCheckpointFindingArgs>,
#[serde(default)]
rejected_findings: Vec<ReviewCheckpointRejectedFindingArgs>,
}

#[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize)]
#[serde(deny_unknown_fields)]
struct ReviewCheckpointChecksArgs {
intended_behavior: String,
regression_risk: String,
missing_tests: String,
docs_config_drift: String,
migration_fallout: String,
operator_facing_fallout: String,
loop_decision_contract: String,
}

#[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize)]
#[serde(deny_unknown_fields)]
struct ReviewCheckpointFindingArgs {
severity: String,
summary: String,
#[serde(default)]
evidence: Vec<String>,
file: Option<String>,
line: Option<u64>,
guidance: String,
}

#[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize)]
#[serde(deny_unknown_fields)]
struct ReviewCheckpointRejectedFindingArgs {
severity: String,
summary: String,
rejection_reason: String,
#[serde(default)]
evidence: Vec<String>,
file: Option<String>,
line: Option<u64>,
}

#[derive(Debug, Serialize)]
struct NormalizedReviewCheckpointPayload {
reviewer: String,
checks: ReviewCheckpointChecksArgs,
evidence: Vec<String>,
accepted_findings: Vec<ReviewCheckpointFindingArgs>,
rejected_findings: Vec<ReviewCheckpointRejectedFindingArgs>,
}

#[derive(Debug, Deserialize)]
Expand Down
3 changes: 3 additions & 0 deletions apps/decodex/src/agent/tracker_tool_bridge/review.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ impl<'a> TrackerToolBridge<'a> {
review_policy_status: ReviewPolicyStatus,
head_sha: &str,
nonclean_rounds: i64,
details_json: &str,
) -> Result<(), String> {
let state_store = self.state_store.ok_or_else(|| {
format!(
Expand All @@ -99,6 +100,7 @@ impl<'a> TrackerToolBridge<'a> {
status: review_policy_status.as_str(),
head_sha,
nonclean_rounds,
details_json,
})
.map_err(|error| {
format!(
Expand Down Expand Up @@ -980,6 +982,7 @@ impl<'a> TrackerToolBridge<'a> {
status: status.as_str(),
head_sha,
nonclean_rounds,
details_json: "{}",
})?;

Ok(Some(ReviewPolicyState {
Expand Down
Loading