Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
487 changes: 487 additions & 0 deletions artifacts/github/bundles/openai-codex-pr-25018.json

Large diffs are not rendered by default.

290 changes: 290 additions & 0 deletions artifacts/github/bundles/openai-codex-pr-26041.json

Large diffs are not rendered by default.

191 changes: 191 additions & 0 deletions artifacts/github/bundles/openai-codex-pr-27259.json

Large diffs are not rendered by default.

438 changes: 438 additions & 0 deletions artifacts/github/bundles/openai-codex-pr-27304.json

Large diffs are not rendered by default.

47 changes: 47 additions & 0 deletions artifacts/github/impact/openai-codex-pr-25018.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"schema": "upstream_impact/v1",
"slug": "openai-codex-pr-25018",
"repo": "openai/codex",
"source_refs": {
"items": [
{
"kind": "pull_request",
"title": "Add app-server `thread/delete` API",
"url": "https://github.com/openai/codex/pull/25018",
"meta": "Merged 2026-06-10T18:22:12Z"
},
{
"kind": "pull_request",
"title": "Source-backed Decodex upstream review",
"url": "https://github.com/openai/codex/pull/25018",
"meta": "artifacts/github/reviews/openai-codex-pr-25018.review.json"
}
]
},
"observed_change": "Codex added app-server v2 `thread/delete` request and `thread/deleted` notification support for hard-deleting active or archived threads plus spawned descendants and associated local state.",
"public_signal_decision": "publish",
"control_plane_impact": "compat_risk",
"publisher_angle": "operator_impact",
"confidence": "confirmed",
"evidence": [
"The upstream review records new `ThreadDelete` request and `ThreadDeleted` notification protocol wiring.",
"The app-server README documents hard-delete semantics for active or archived threads and spawned descendants.",
"Local thread-store code deletes rollout files before reporting success.",
"State DB deletion expands to associated goals, spawn edges, logs, dynamic tools, and agent job assignments."
],
"candidate_followups": [
"Gate Decodex hard-delete UX behind explicit operator confirmation and clear archive-versus-delete wording.",
"Update thread list and subagent caches on `thread/deleted` notifications.",
"Define Decodex policy for remote thread stores before exposing a generic delete path."
],
"social_notes": [
"Public copy should stress hard delete and descendant cleanup, not just a new method name.",
"Avoid presenting delete as reversible archive.",
"Mention `thread/deleted` notifications because clients must update local state."
],
"caveats": [
"Remote or hosted thread-store behavior may differ until implemented.",
"The operation is intentionally destructive.",
"The PR is app-server and local-store source evidence, not an endorsement to auto-delete user threads."
]
}
47 changes: 47 additions & 0 deletions artifacts/github/impact/openai-codex-pr-26041.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"schema": "upstream_impact/v1",
"slug": "openai-codex-pr-26041",
"repo": "openai/codex",
"source_refs": {
"items": [
{
"kind": "pull_request",
"title": "Add app-server background terminal process APIs",
"url": "https://github.com/openai/codex/pull/26041",
"meta": "Merged 2026-06-10T18:18:09Z"
},
{
"kind": "pull_request",
"title": "Source-backed Decodex upstream review",
"url": "https://github.com/openai/codex/pull/26041",
"meta": "artifacts/github/reviews/openai-codex-pr-26041.review.json"
}
]
},
"observed_change": "Codex added experimental app-server v2 APIs for listing and terminating background terminal processes for a loaded thread, using unified-exec process manager state as the source of truth.",
"public_signal_decision": "publish",
"control_plane_impact": "adopt_now",
"publisher_angle": "operator_impact",
"confidence": "confirmed",
"evidence": [
"The upstream review records `thread/backgroundTerminals/list` and `thread/backgroundTerminals/terminate` as new experimental app-server methods.",
"Protocol structs include background terminal params, records, pagination, terminate params, and terminate response fields.",
"Unified-exec process manager state now carries metadata needed for background terminal records.",
"The app-server README documents the capability gate and method behavior."
],
"candidate_followups": [
"Create a bounded Decodex adoption issue for app-server background terminal list and terminate support.",
"Prefer app-server process ids over local OS PID discovery in operator UI where the new API is available.",
"Preserve nullability for OS PID, CPU, RSS, and other host-dependent terminal metadata."
],
"social_notes": [
"Public copy can present this as background terminal management moving into app-server protocol.",
"Call out that the APIs are experimental and capability-gated.",
"Use direct PR reference for the method names and fields."
],
"caveats": [
"The methods are experimental.",
"The APIs apply to loaded-thread background terminals managed by unified-exec.",
"Some process metadata fields are nullable."
]
}
47 changes: 47 additions & 0 deletions artifacts/github/impact/openai-codex-pr-27259.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"schema": "upstream_impact/v1",
"slug": "openai-codex-pr-27259",
"repo": "openai/codex",
"source_refs": {
"items": [
{
"kind": "pull_request",
"title": "Use latest-wins MCP manager replacement",
"url": "https://github.com/openai/codex/pull/27259",
"meta": "Merged 2026-06-10T15:33:21Z"
},
{
"kind": "pull_request",
"title": "Source-backed Decodex upstream review",
"url": "https://github.com/openai/codex/pull/27259",
"meta": "artifacts/github/reviews/openai-codex-pr-27259.review.json"
}
]
},
"observed_change": "Codex replaced the session-owned `RwLock<McpConnectionManager>` publication path with latest-wins `ArcSwap` handles, so each MCP operation keeps the manager it loaded while refresh atomically publishes a replacement.",
"public_signal_decision": "publish",
"control_plane_impact": "compat_risk",
"publisher_angle": "operator_impact",
"confidence": "confirmed",
"evidence": [
"The upstream review records the `ArcSwap<McpConnectionManager>` replacement in session services.",
"MCP tool, resource, elicitation, and connector paths now use `.load_full()` instead of holding an async read guard.",
"Session shutdown explicitly aborts startup prewarm before loading and shutting down the current MCP manager.",
"Regression coverage exercises pending tool-list cancellation and startup-prewarm shutdown."
],
"candidate_followups": [
"Audit Decodex MCP refresh and hosted-plugin probes for assumptions that manager refresh drains in-flight calls.",
"Treat manager handles as per-operation snapshots when reasoning about MCP tool, resource, and elicitation behavior.",
"Document any Control Plane expectations around terminal shutdown interrupting MCP operations."
],
"social_notes": [
"Frame this as a synchronization model change for MCP operators, not as a new MCP user command.",
"Mention latest-wins replacement and owned loaded handles.",
"Preserve the caveat that refresh is expected at turn boundaries."
],
"caveats": [
"The change is internal to Codex MCP manager ownership.",
"The PR does not claim arbitrary mid-tool-call refresh safety beyond retained manager handles.",
"Shutdown may still interrupt active terminal or model work."
]
}
47 changes: 47 additions & 0 deletions artifacts/github/impact/openai-codex-pr-27304.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"schema": "upstream_impact/v1",
"slug": "openai-codex-pr-27304",
"repo": "openai/codex",
"source_refs": {
"items": [
{
"kind": "pull_request",
"title": "[codex] Remove async_trait from ToolExecutor",
"url": "https://github.com/openai/codex/pull/27304",
"meta": "Merged 2026-06-10T17:26:53Z"
},
{
"kind": "pull_request",
"title": "Source-backed Decodex upstream review",
"url": "https://github.com/openai/codex/pull/27304",
"meta": "artifacts/github/reviews/openai-codex-pr-27304.review.json"
}
]
},
"observed_change": "Codex removed `async_trait` from the `ToolExecutor` trait and converted handlers to return a boxed `ToolExecutorFuture` directly.",
"public_signal_decision": "publish",
"control_plane_impact": "compat_risk",
"publisher_angle": "practical_explainer",
"confidence": "confirmed",
"evidence": [
"`ToolExecutorFuture<'a>` is added and exported from `codex-tools` and `codex-extension-api`.",
"`ToolExecutor` no longer carries the `#[async_trait::async_trait]` annotation.",
"Bundled extensions remove direct `async-trait` dependencies.",
"Tool handlers across core and extension surfaces now return explicit boxed futures."
],
"candidate_followups": [
"Check Decodex-owned extension examples for old async `ToolExecutor::handle` implementations.",
"Update migration notes or snippets to use `ToolExecutorFuture` and `Box::pin` when relevant.",
"Track stacked PR #27299 if a later review needs the full handler-outline context."
],
"social_notes": [
"Useful public copy should target extension authors and explain the new trait implementation shape.",
"Avoid implying a model-visible runtime feature was added.",
"Mention the PR body's build-speed motivation only as author-reported context."
],
"caveats": [
"The change is source/API facing for extension and tool implementors.",
"The PR body says it is stacked on #27299.",
"No app-server method or CLI command is added by this PR alone."
]
}
Loading