Skip to content

XY-908: Document no-compat release gate for review config #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 3 commits into from
Jun 11, 2026
Merged

XY-908: Document no-compat release gate for review config #314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d8cd5
{"schema":"decodex/commit/1","summary":"Document no-compat review con…
yvette-carlisle Jun 11, 2026
e6d20a8
{"schema":"decodex/commit/1","summary":"Clarify release gate legacy-k…
yvette-carlisle Jun 11, 2026
e0223bf
{"schema":"decodex/commit/1","summary":"Narrow legacy-key gate except…
yvette-carlisle Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions docs/runbook/release-readiness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ Collect evidence in this order:
```

3. Scan checked-in docs, skills, examples, and config templates for historical review
config fields. The literal old field names may appear only in migration history.
config fields. Because this bullet names the removed keys to define the check,
allow `internal_review_mode` and `external_review_enabled` in this bullet and in
migration history only. They must not appear in active project configs, examples,
templates, or other release procedures.
4. Run the registered project gate before any pushed PR head. This mirrors the
registered `WORKFLOW.md` order: canonicalize first, then verify.

Expand All @@ -58,7 +61,9 @@ Collect evidence in this order:

7. Run focused loop, review, config, prompt, dry-run, and recovery checks selected
from the landed dependency changes. At minimum include review-level and config
coverage:
coverage. Text search from step 3 is not sufficient: the release evidence must
show the active project config parser rejects those removed fields, while the
current `[codex].review` model remains covered by review/config tests.

```sh
cargo test -p decodex review --all-features -- --test-threads=1
Expand Down