Fix retained progress handling for retryable runtime failures - #347
Merged
Conversation
…es with retained progress","authority":"manual","related":["XY-941"]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
XY-941 attempt 1 reached validation-ready work with dirty tracked changes, but the retryable failure branch wrote generic retry/idle handling before retained-progress terminal handling could own the lane. That made the lane look abnormally idle instead of a clear manual takeover point.
Validation
cargo test -p decodex retryable_runtime_failure_with_retained_tracked_changes_records_retained_partial_progress --all-featurescargo test -p decodex loop_guardrail_does_not_classify_dirty_retained_diff_as_no_effective_diff --all-featurescargo test -p decodex retryable_failures_ignore_prior_continuation_attempts_in_writeback --all-featurescargo make fmtcargo make lint-fixcargo make testcargo make checkgit diff --check