Skip to content

Persist upstream Radar review artifacts #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
Jun 15, 2026
Merged

Persist upstream Radar review artifacts #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
304 changes: 304 additions & 0 deletions artifacts/github/bundles/openai-codex-pr-26662.json
View file
Open in desktop

Large diffs are not rendered by default.

296 changes: 296 additions & 0 deletions artifacts/github/bundles/openai-codex-pr-28122.json
View file
Open in desktop

Large diffs are not rendered by default.

47 changes: 47 additions & 0 deletions artifacts/github/impact/openai-codex-pr-26662.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"candidate_followups": [
"Evaluate using `thread/list.parentThreadId` in Decodex operator UI and recovery paths that need direct child-thread visibility.",
"Preserve existing thread-list filters and cursor behavior when adding parent-filtered child-thread queries.",
"Treat unavailable state DB for parent-filtered listing as a capability/readiness state rather than silently falling back to rollout scans."
],
"caveats": [
"`parentThreadId` is explicitly experimental.",
"The filter returns direct spawned children only; it does not recursively return descendants.",
"Review and Guardian threads are intentionally outside this spawned-child lifecycle."
],
"confidence": "confirmed",
"control_plane_impact": "candidate",
"evidence": [
"App-server `ThreadListParams` adds experimental optional `parentThreadId`.",
"The thread processor parses `parentThreadId` into the existing thread-list filter path.",
"Local thread-store routing uses the state DB for parent-filtered listing.",
"State runtime adds `list_threads_by_parent` against persisted spawn edges.",
"The source-backed review is recorded at `artifacts/github/reviews/openai-codex-pr-26662.review.json`."
],
"observed_change": "Codex adds an experimental `thread/list.parentThreadId` filter that returns direct spawned child threads from persisted spawn-edge state while preserving the existing list response shape and filters.",
"public_signal_decision": "publish",
"publisher_angle": "operator_impact",
"repo": "openai/codex",
"schema": "upstream_impact/v1",
"slug": "openai-codex-pr-26662",
"social_notes": [
"Frame this as an app-server recovery and subagent-visibility improvement.",
"Do not imply recursive thread-tree listing or stable API status; the field is experimental and direct-child only."
],
"source_refs": {
"items": [
{
"kind": "pull_request",
"meta": "Merged 2026-06-14T07:14:27Z",
"title": "feat(app-server): filter threads by parent",
"url": "https://github.com/openai/codex/pull/26662"
},
{
"kind": "pull_request",
"meta": "artifacts/github/reviews/openai-codex-pr-26662.review.json",
"title": "Source-backed Decodex upstream review",
"url": "https://github.com/openai/codex/pull/26662"
}
]
}
}
47 changes: 47 additions & 0 deletions artifacts/github/impact/openai-codex-pr-28122.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"candidate_followups": [
"Audit Decodex Control Plane paths that construct or consume `TurnEnvironmentSelection` and preserve `PathUri` instead of normalizing everything to local absolute paths.",
"Use selected remote-environment shell information when bridging unified exec into remote executor sessions.",
"Expose unsupported foreign cwd request-permissions responses as cross-host path compatibility states instead of retrying them as transient process failures."
],
"caveats": [
"The PR does not make every request-permissions path foreign-host aware; native-only boundaries remain explicit.",
"Unified exec falls back to the session shell when the selected environment does not report a shell.",
"Decodex implementation work still needs a separate issue if local Control Plane code assumes selected environment cwd is always host-native."
],
"confidence": "confirmed",
"control_plane_impact": "compat_risk",
"evidence": [
"`TurnEnvironmentSelection.cwd` changed from `AbsolutePathBuf` to `PathUri`.",
"App-server thread and turn processors convert local cwd values into `PathUri` selections.",
"Core environment selection converts cwd URI values back to absolute paths only at native-only consumer boundaries.",
"Unified exec now prefers the selected environment shell and falls back to the session shell when absent.",
"The source-backed review is recorded at `artifacts/github/reviews/openai-codex-pr-28122.review.json`."
],
"observed_change": "Codex changes turn environment cwd handling to preserve `PathUri` values and makes unified exec prefer the selected remote environment's native shell.",
"public_signal_decision": "publish",
"publisher_angle": "operator_impact",
"repo": "openai/codex",
"schema": "upstream_impact/v1",
"slug": "openai-codex-pr-28122",
"social_notes": [
"Frame this as remote-exec cwd and native-shell compatibility for Control Plane integrations.",
"Do not imply all foreign cwd request-permissions paths are fully supported; the PR records current native-only rejection."
],
"source_refs": {
"items": [
{
"kind": "pull_request",
"meta": "Merged 2026-06-14T06:07:47Z",
"title": "[codex] exec-server honors remote environment cwd and shell",
"url": "https://github.com/openai/codex/pull/28122"
},
{
"kind": "pull_request",
"meta": "artifacts/github/reviews/openai-codex-pr-28122.review.json",
"title": "Source-backed Decodex upstream review",
"url": "https://github.com/openai/codex/pull/28122"
}
]
}
}
199 changes: 113 additions & 86 deletions artifacts/github/review-queue/openai-codex-latest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"recent_commits_scanned": 40,
"subjects_queued": 40
},
"generated_at": "2026-06-14T06:06:44.836542Z",
"generated_at": "2026-06-14T18:06:03.813491Z",
"repo": "openai/codex",
"schema": "upstream_review_queue/v1",
"source": {
Expand All @@ -17,91 +17,6 @@
"signals_dir": "site/src/content/signals"
},
"subjects": [
{
"attention_flags": [
"auth_account",
"breaking_change",
"deprecated_removed",
"new_feature",
"protocol_change",
"security_policy"
],
"changed_file_count": 8,
"commit_shas": [
"07d66eccd904cd15cd754c43d3f74a72d63a1980",
"3e3379b56006b9e877f5db4ba65009b4ad41c49c"
],
"committed_at": "2026-06-12T19:15:21Z",
"next_step": "ai_review_required",
"pr_number": 27504,
"pr_url": "https://github.com/openai/codex/pull/27504",
"review_priority": "critical",
"review_reason": "Needs AI review for auth_account, breaking_change, deprecated_removed, new_feature, protocol_change, security_policy.",
"sample_paths": [
"codex-rs/config/src/types.rs",
"codex-rs/core/config.schema.json",
"codex-rs/core/src/config/auth_keyring.rs",
"codex-rs/core/src/config/auth_keyring_tests.rs",
"codex-rs/core/src/config/config_tests.rs",
"codex-rs/core/src/config/mod.rs",
"codex-rs/features/src/lib.rs",
"codex-rs/features/src/tests.rs"
],
"source_state": "merged",
"subject_id": "27504",
"subject_kind": "pr",
"surface_hints": [
"auth_accounts",
"config_hooks",
"tests_ci"
],
"title": "feat: add secret auth storage configuration",
"url": "https://github.com/openai/codex/pull/27504"
},
{
"attention_flags": [
"auth_account",
"deprecated_removed",
"new_feature",
"protocol_change",
"security_policy"
],
"changed_file_count": 9,
"commit_shas": [
"bfd992f6dbf9acffcbdafbcee3c092d729725759",
"94185dff59cd43d21450db876ab4b595383ae959",
"f45d36dc66dfe7eba7478c6921a69ced53a92c07",
"21c45654a19f658a83b37ada768ab8e109f06955"
],
"committed_at": "2026-06-12T19:38:30Z",
"next_step": "ai_review_required",
"pr_number": 27674,
"pr_url": "https://github.com/openai/codex/pull/27674",
"review_priority": "critical",
"review_reason": "Needs AI review for auth_account, deprecated_removed, new_feature, protocol_change, security_policy.",
"sample_paths": [
"codex-rs/Cargo.lock",
"codex-rs/cli/Cargo.toml",
"codex-rs/cli/src/login.rs",
"codex-rs/cli/tests/login.rs",
"codex-rs/login/src/auth/manager.rs",
"codex-rs/login/src/auth/mod.rs",
"codex-rs/login/src/auth/revoke.rs",
"codex-rs/login/src/server.rs",
"codex-rs/login/tests/suite/logout.rs"
],
"source_state": "merged",
"subject_id": "27674",
"subject_kind": "pr",
"surface_hints": [
"auth_accounts",
"cli_tui",
"config_hooks",
"tests_ci"
],
"title": "[login] revoke existing auth before starting login",
"url": "https://github.com/openai/codex/pull/27674"
},
{
"attention_flags": [
"auth_account",
Expand Down Expand Up @@ -861,6 +776,118 @@
"title": "build: run buildifier from just fmt",
"url": "https://github.com/openai/codex/pull/28125"
},
{
"attention_flags": [
"auth_account",
"breaking_change",
"new_feature",
"protocol_change",
"release_packaging",
"security_policy"
],
"changed_file_count": 22,
"commit_shas": [
"a2a917b071ce164777333349163005720c8c5e7f",
"019ff65142c38263fd685f9692670aeeb560c5c6",
"5bada3f2a4f18a252cd65d89f461d3ff3c9f4b1f",
"2a8b87ed44215e4bf0bcce6b778038874c720b51",
"310ccf29f684a7a19ae65ea790bd465cfe74cb2a",
"763357aaa79a5fb13f84a5013deb2ff284a67bd4",
"ce4102787545b9131e32619e43ed89dc0ad13f12",
"4f6dd50b0eb01f3548c7b1403017e74c8697ef51",
"f4db0780fc9ef2063e29847f851759c5bd97dbe1",
"25644e0ec49ebf371ab45c8ae73b3cb8fd78607e",
"18004b9322a89dd9efc40aea3f88643cdfc55eed",
"716e9e32e934a3f7b868a1bc7a327524594dc81e",
"1a7dbd5b4ff43cdf230f8b7062e6c1618ed458dc"
],
"committed_at": "2026-06-14T06:07:46Z",
"next_step": "ai_review_required",
"pr_number": 28122,
"pr_url": "https://github.com/openai/codex/pull/28122",
"review_priority": "critical",
"review_reason": "Needs AI review for auth_account, breaking_change, new_feature, protocol_change, release_packaging, security_policy.",
"sample_paths": [
"bazel/rules/testing/wine/src/lib.rs",
"bazel/rules/testing/wine/src/lib_tests.rs",
"codex-rs/Cargo.lock",
"codex-rs/app-server/src/request_processors/thread_processor.rs",
"codex-rs/app-server/src/request_processors/turn_processor.rs",
"codex-rs/core/src/environment_selection.rs",
"codex-rs/core/src/session/mod.rs",
"codex-rs/core/src/session/tests.rs",
"codex-rs/core/src/session/turn_context.rs",
"codex-rs/core/src/thread_manager_tests.rs",
"codex-rs/core/src/tools/handlers/unified_exec/exec_command.rs",
"codex-rs/core/tests/common/test_codex.rs"
],
"source_state": "merged",
"subject_id": "28122",
"subject_kind": "pr",
"surface_hints": [
"app_server_protocol",
"cli_tui",
"config_hooks",
"tests_ci"
],
"title": "[codex] exec-server honors remote environment cwd and shell",
"url": "https://github.com/openai/codex/pull/28122"
},
{
"attention_flags": [
"auth_account",
"breaking_change",
"deprecated_removed",
"new_feature",
"protocol_change",
"security_policy"
],
"changed_file_count": 27,
"commit_shas": [
"68567deb6f6e9227662c9558d37ff3e280a2b377",
"724cd58bf6ed04ffaf8ab8520c951a5518f3161a",
"c2f877a1d0c5dbab82f5d7fcb4c591b90e9541f8",
"e06ed34720737e1657c74fdc466972c5fdda5ac4",
"eaeb92854e2d6da708558a8f0b81ff7cacdfd569",
"4c1fbf28545273cd4ba9402a4065171b646824f9",
"28d35a99eff66cf06742933e4a45fde47fb927d5",
"ba23593c751b155e4a86d2e6c24125a4b177a8c6",
"95d0018d71d9b15ccac883561abd1d408cf0f875",
"688537c78d85337d3bc70e80a7e74fcfe11da6ce"
],
"committed_at": "2026-06-14T07:14:26Z",
"next_step": "ai_review_required",
"pr_number": 26662,
"pr_url": "https://github.com/openai/codex/pull/26662",
"review_priority": "critical",
"review_reason": "Needs AI review for auth_account, breaking_change, deprecated_removed, new_feature, protocol_change, security_policy.",
"sample_paths": [
"codex-rs/app-server-protocol/schema/typescript/v2/ThreadListParams.ts",
"codex-rs/app-server-protocol/src/protocol/common.rs",
"codex-rs/app-server-protocol/src/protocol/v2/thread.rs",
"codex-rs/app-server-test-client/src/lib.rs",
"codex-rs/app-server/README.md",
"codex-rs/app-server/src/request_processors/thread_processor.rs",
"codex-rs/app-server/tests/suite/v2/external_agent_config.rs",
"codex-rs/app-server/tests/suite/v2/remote_thread_store.rs",
"codex-rs/app-server/tests/suite/v2/thread_fork.rs",
"codex-rs/app-server/tests/suite/v2/thread_list.rs",
"codex-rs/app-server/tests/suite/v2/thread_read.rs",
"codex-rs/core/src/personality_migration.rs"
],
"source_state": "merged",
"subject_id": "26662",
"subject_kind": "pr",
"surface_hints": [
"app_server_protocol",
"cli_tui",
"config_hooks",
"docs_examples",
"tests_ci"
],
"title": "feat(app-server): filter threads by parent",
"url": "https://github.com/openai/codex/pull/26662"
},
{
"attention_flags": [
"auth_account",
Expand Down
Loading