Skip to content

Fix review handoff drift failure handling - #405

Merged
yvette-carlisle merged 1 commit into
mainfrom
xy/review-handoff-drift-kernel
Jun 16, 2026
Merged

Fix review handoff drift failure handling#405
yvette-carlisle merged 1 commit into
mainfrom
xy/review-handoff-drift-kernel

Conversation

@yvette-carlisle

Copy link
Copy Markdown
Member

Summary

  • Treat retained review handoff as a failure-handling lifecycle boundary before retry/no-diff guardrails run.
  • Recover trusted handoff drift by rebuilding review orchestration, clearing stale loop guardrail checkpoints, restoring review state, and marking the failed attempt succeeded.
  • Fail closed with review_handoff_state_drift when the clean checkpoint/marker evidence is missing, mismatched, diverged, unknown, or in an unsupported tracker state.
  • Document the post-review lifecycle boundary in runtime, lane-control, and post-review specs.

Verification

  • cargo test -p decodex review_handoff_state_drift -- --nocapture
  • cargo test -p decodex handoff_marker_issue_state_is_unsupported -- --nocapture
  • cargo test -p decodex handoff_marker_head_ref_mismatches -- --nocapture
  • cargo test -p decodex -- --test-threads=1 (1176 passed, 1 ignored before final unsupported-state regression)
  • cargo make checks (1177 passed, 1 skipped)

Notes

  • npm ci was required locally because the site dependency tree was not installed in this worktree; no dependency files were changed.

@yvette-carlisle
yvette-carlisle added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 87d3c8e Jun 16, 2026
14 checks passed
@yvette-carlisle
yvette-carlisle deleted the xy/review-handoff-drift-kernel branch June 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant