Adopt app-server notification turn ids#414
Merged
Merged
Conversation
… turn ids","authority":"manual"}
…id adoption","authority":"manual"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn/startresponse idsRoot cause
Decodex tolerated app-server turn id drift for dynamic tracker tool calls, but the completion loop still filtered
turn/completedagainst theturn/startresponse id. Same-thread completion notifications were recorded as protocol events but ignored as active turn completion, so phase goal readback did not run and lanes could stay red inagent_run/repo_gate.Validation
cargo test -p decodex agent::app_server::tests::phase_goal -- --nocapturecargo test -p decodex agent::app_server::tests:: -- --nocapturerustup run nightly cargo fmt --all -- --checkcargo make fmt-checkgit diff --checkcargo make test