improve footer accessibility and dynamic copyright year#2018
Open
evanxdsouza wants to merge 3 commits into
Open
improve footer accessibility and dynamic copyright year#2018evanxdsouza wants to merge 3 commits into
evanxdsouza wants to merge 3 commits into
Conversation
Contributor
|
@evanxdsouza is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the site footer by making the Hack Club logo link to the homepage, adding accessibility improvements, and switching the copyright year from hardcoded to dynamic. However, the current Footer.tsx changes introduce invalid JSX that will prevent the app from compiling, and the PR also includes several large unrelated public data/font additions not reflected in the PR description.
Changes:
- Update footer link handling helpers (
ext→isExternal/isMailto) and make the copyright year dynamic. - Wrap the Hack Club logo in a homepage link and add an aria-label for the phone link.
- Add new public data files (
team.json,acknowledged.json,donors.json) and a new font file (zarathustra-v01.otf).
Reviewed changes
Copilot reviewed 1 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| components/Footer.tsx | Footer refactor + dynamic year + accessibility tweaks (currently contains invalid JSX that breaks build). |
| public/team.json | Adds a large team dataset used by /team and /api/team. |
| public/acknowledged.json | Adds a large acknowledged-members dataset used by /api/acknowledged. |
| public/donors.json | Adds a donors mapping file (appears unused in the codebase). |
| public/font/zarathustra-v01.otf | Adds an OTF font file (no current references; app uses zarathustra-kerned.ttf). |
Comments suppressed due to low confidence (3)
components/Footer.tsx:178
- The phone link markup is missing the opening
<a>tag, so thehref,aria-label, andstyleprops are currently not attached to any element (invalid JSX / compile error). Restore the<a>element around this block.
href="tel:18556254225"
aria-label="Call Hack Club toll-free at 1-855-625-4225"
style={{
fontWeight: 400,
components/Footer.tsx:196
- The social icon links are missing the opening
<a>tag inside theicons.maploop, leavingkey,href, etc. as stray attributes and breaking compilation. Restore the<a>wrapper for each icon.
<div style={{ display: "flex", gap: 12 }}>
{icons.map((i) => (
key={i.label}
href={i.href}
target={isExternal(i.href) ? "_blank" : undefined}
rel={isExternal(i.href) ? "noopener noreferrer" : undefined}
components/Footer.tsx:239
- Both footer text links (Hack Foundation + GitHub) are missing their opening
<a>tags, so thehref/target/rel/styleprops are not attached to an element (invalid JSX). Restore the<a>elements for these links.
© {year} Hack Club. Registered under{" "}
href="https://the.hackfoundation.org/"
target="_blank"
rel="noopener noreferrer"
style={{ color: "#fff", textDecoration: "underline", textUnderlineOffset: 2 }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
59
| function isMailto(href: string) { | ||
| return href.startsWith("mailto:"); | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to Hack CLub logo to link to the home page. We can write a script so it links to the nearest HC event or a random page or a surprise Easter egg.
Also improved accessibility of the footer.
CHanged the copyright year from harcoded to dynamic