Skip to content

HCK-17370: Fix column order in CREATE INDEX ddl #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitaliiBedletskyi merged 2 commits into from
Aug 14, 2026
Merged

HCK-17370: Fix column order in CREATE INDEX ddl #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a82ccb
HCK-17370: Fix column order in CREATE INDEX ddl
kyrylo-burmelov Aug 14, 2026
ffb0bb5
Merge branch 'develop' into HCK-17370
kyrylo-burmelov Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions forward_engineering/ddlProvider/ddlHelpers/index/getIndexOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ const toUpperCase = value => toUpper(value);
const getUpperCaseValue = prefix => getBasicValue({ prefix, modifier: toUpperCase });

/**
* Build index key list clause. The model stores the order as `ascending`/`descending`, which Db2 for z/OS spells
* `ASC`/`DESC`.
* Build index key list clause.
*
* @param {IndexKeyRef[]} [keys] Index keys.
* @returns {string} Keys clause.
Expand Down
3 changes: 1 addition & 2 deletions forward_engineering/utils/general.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ const columnMapToString = ({ name }) => wrapInQuotes(name ?? '');
* @returns {string} Column expression.
*/
const columnMapToStringWithOrder = ({ name, type }) => {
const order = type === 'descending' ? ' DESC' : type === 'ascending' ? ' ASC' : '';
return wrapInQuotes(name) + order;
return [wrapInQuotes(name), type].filter(Boolean).join(' ');
};

/**
Expand Down
2 changes: 1 addition & 1 deletion properties_pane/entity_level/entityLevelConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ making sure that you maintain a proper JSON format.
"propertyTooltip": "Index key columns with ASC, DESC, or RANDOM ordering.",
"propertyType": "fieldList",
"template": "orderedList",
"attributeList": ["asc", "desc", "random"],
"attributeList": ["", "ASC", "DESC", "RANDOM"],
"validation": {
"minLength": 1,
"required": true
Expand Down