Remove confusing lanes parameter to Handle#9198
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9198 +/- ##
=======================================
Coverage ? 70.06%
=======================================
Files ? 255
Lines ? 78936
Branches ? 18881
=======================================
Hits ? 55307
Misses ? 17904
Partials ? 5725 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexreinking
commented
Jul 13, 2026
The call to `Handle(64)` confused the number of bit a Handle always has (64) with the number of lanes (the actual argument, 1 by default).
alexreinking
force-pushed
the
alexreinking/generator-handle-bug
branch
from
July 21, 2026 06:00
4a4fb37 to
b372dd8
Compare
alexreinking
changed the title
alexreinking
added
the
code_cleanup
shoaibkamil
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
Handle(64)confused the number of bit a Handle always has (64) with the number of lanes (the actual argument, 1 by default). Nothing in the compiler used that argument at all, so we remove this foot-gun from the API. If a client needs a vector of Handles, they can use.with_lanes().