Skip to content

check serialized vector lengths before indexing in deserializer #9216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nashit-h wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

check serialized vector lengths before indexing in deserializer #9216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Deserialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,9 @@ std::vector<Expr> Deserializer::deserialize_expr_vector(const flatbuffers::Vecto
const flatbuffers::Vector<flatbuffers::Offset<void>> *exprs_serialized) {
user_assert(exprs_types != nullptr);
user_assert(exprs_serialized != nullptr);
user_assert(exprs_types->size() == exprs_serialized->size())
<< "deserialized expr vector carries " << exprs_serialized->size()
<< " exprs, but " << exprs_types->size() << " type codes\n";
std::vector<Expr> result;
result.reserve(exprs_serialized->size());
for (size_t i = 0; i < exprs_serialized->size(); ++i) {
Expand Down Expand Up @@ -1163,6 +1166,9 @@ FuseLoopLevel Deserializer::deserialize_fuse_loop_level(const Serialize::FuseLoo
for (const auto &align_strategy : *fuse_loop_level->align_strategies()) {
align_strategies.push_back(deserialize_loop_align_strategy((Serialize::LoopAlignStrategy)align_strategy));
}
user_assert(align_dimension_names.size() == align_strategies.size())
<< "deserialized fuse loop level carries " << align_dimension_names.size()
<< " align dimension names, but " << align_strategies.size() << " align strategies\n";
std::map<std::string, LoopAlignStrategy> align;
for (size_t i = 0; i < align_dimension_names.size(); ++i) {
align[align_dimension_names[i]] = align_strategies[i];
Expand Down Expand Up @@ -1311,6 +1317,10 @@ Buffer<> Deserializer::deserialize_buffer(const Serialize::Buffer *buffer) {
const std::string name = deserialize_string(buffer->name());
const auto type = deserialize_type(buffer->type());
const int32_t dimensions = buffer->dimensions();
user_assert(buffer->dims() != nullptr) << "deserialized buffer " << name << " has no dims\n";
user_assert(dimensions >= 0 && (size_t)dimensions == buffer->dims()->size())
<< "deserialized buffer " << name << " declares " << dimensions
<< " dimensions, but carries " << buffer->dims()->size() << " of them\n";
std::vector<halide_dimension_t> hl_buffer_dimensions;
std::vector<halide_dimension_t> dense_buffer_dimensions;
hl_buffer_dimensions.reserve(dimensions);
Expand Down Expand Up @@ -1473,6 +1483,10 @@ Pipeline Deserializer::deserialize(const std::vector<uint8_t> &data) {
}

std::vector<Func> funcs;
user_assert(pipeline_obj->funcs() != nullptr) << "deserialized pipeline has no funcs\n";
user_assert(pipeline_obj->funcs()->size() == functions.size())
<< "deserialized pipeline carries " << pipeline_obj->funcs()->size()
<< " funcs, but " << functions.size() << " func names\n";
for (size_t i = 0; i < pipeline_obj->funcs()->size(); ++i) {
deserialize_function(pipeline_obj->funcs()->Get(i), functions[i]);
funcs.emplace_back(functions[i]);
Expand Down
Loading