Skip to content

[python] Test: disable incremental linking for Windows AOT runtime test modules #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexreinking wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Draft

[python] Test: disable incremental linking for Windows AOT runtime test modules #9415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions python_bindings/halide-runtime/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@ function(add_runtime_test_kernel MOD)
add_library(${MOD}_module MODULE aot_module_stub.c)
target_link_libraries(${MOD}_module PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,${MOD}_aot>")
set_target_properties(${MOD}_module PROPERTIES PREFIX "" OUTPUT_NAME ${MOD})

if (MSVC)
# link.exe's incremental linker can corrupt a /WHOLEARCHIVE module
# (LNK1236: corrupt or invalid COFF sections) when relinking it against
# a changed archive in an existing build tree. These modules are only
# ever built once per configuration, so incremental linking buys us
# nothing and isn't worth the risk.
target_link_options(${MOD}_module PRIVATE /INCREMENTAL:NO)
endif ()
endfunction()

# A tiny kernel: load, call, and Buffer interop.
Expand Down
Loading