Skip to content

Print the actual Expr for an add_requirement() that fails. #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcourteaux merged 2 commits into from
Sep 3, 2026
+8 −5
Merged

Print the actual Expr for an add_requirement() that fails. #9424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff1c56a
Put the actual printed IR in the requirement_failed string. The simpl…
mcourteaux Sep 3, 2026
0e1f87a
clang-tidy...
mcourteaux Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python_bindings/halide/test/correctness/basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,13 @@ def test_requirements():
delta.set(1)
p.realize([10])

with assert_throws(hl.HalideError, r"Requirement Failed: \(false\)"):
with assert_throws(hl.HalideError, r"Requirement Failed: \(\(delta != 0\)\)"):
delta.set(0)
p.realize([10])

with assert_throws(
hl.HalideError, r"Requirement Failed: \(false\) negative values are bad -1"
hl.HalideError,
r"Requirement Failed: \(\(delta > 0\)\) negative values are bad -1",
):
delta.set(-1)
p.realize([10])
Expand Down
6 changes: 4 additions & 2 deletions src/IROperator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,10 +1283,12 @@ Expr unwrap_tags(const Expr &e) {
return e;
}

Expr requirement_failed_error(Expr condition, const std::vector<Expr> &args) {
Expr requirement_failed_error(const Expr &condition, const std::vector<Expr> &args) {
std::stringstream cond_str;
cond_str << condition;
return Call::make(Int(32),
"halide_error_requirement_failed",
{stringify({std::move(condition)}), combine_strings(args)},
{cond_str.str(), combine_strings(args)},
Call::Extern);
}

Expand Down
2 changes: 1 addition & 1 deletion src/IROperator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ inline HALIDE_NO_USER_CODE_INLINE void collect_print_args(std::vector<Expr> &arg
collect_print_args(args, std::forward<Args>(more_args)...);
}

Expr requirement_failed_error(Expr condition, const std::vector<Expr> &args);
Expr requirement_failed_error(const Expr &condition, const std::vector<Expr> &args);

Expr memoize_tag_helper(Expr result, const std::vector<Expr> &cache_key_values);

Expand Down
Loading