Repository navigation
next-steps: wide characters count as two columns - #72
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69. With
languageset to Korean, Japanese or Chinese, the suggestions could land on the one-line layout even when they were too wide for the terminal, and get cut off.fitsOnOneLinemeasured width with.length, which counts every character as one column. CJK, Hangul, full-width forms and emoji take two. A smalldisplayWidthhelper now counts those as two.mods/next-steps/hooks/register.tsx:displayWidth, used byfitsOnOneLinetests/next-steps.test.ts: Hangul width, and a list that fits in ASCII but not in HangulFound by the second-opinion review on #69.
Checks
claude plugin validate mods/next-steps: passedclaude plugin test mods/next-steps: 18 pass, 0 fail🤖 Generated with Claude Code