Skip to content

restrict matplotlib>=3.8#36

Open
AdamOrmondroyd wants to merge 2 commits into
masterfrom
mpl38
Open

restrict matplotlib>=3.8#36
AdamOrmondroyd wants to merge 2 commits into
masterfrom
mpl38

Conversation

@AdamOrmondroyd

@AdamOrmondroyd AdamOrmondroyd commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Restrict to matplotlib>=3.8.0 due to api change. We (I) updated the fgivenx api in #26, but didn't restrict the setup.py (as it was back then) accordingly.

Somewhat helps wth #35 but the feedstock will still need fiddling

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

I guess technically this is a breaking change, though it feels more like a broken change. smh my head

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6de719a) to head (51935a0).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          861       861           
=========================================
  Hits           861       861           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant