Skip to content

Fetch hyperformula-tests before running linter#1672

Merged
sequba merged 1 commit into
developfrom
fix-lint-action-on-gh
May 11, 2026
Merged

Fetch hyperformula-tests before running linter#1672
sequba merged 1 commit into
developfrom
fix-lint-action-on-gh

Conversation

@sequba
Copy link
Copy Markdown
Contributor

@sequba sequba commented May 11, 2026

Summary

The lint GitHub Action did not check out the hyperformula-tests repository before running ESLint. As a result, lint errors inside files under test/hyperformula-tests/ were silently skipped in CI and only surfaced when running npm run lint locally.

This PR aligns .github/workflows/lint.yml with .github/workflows/test.yml so the linter sees the same source tree as the test jobs.

Changes

  • .github/workflows/lint.yml
    • Add a Checkout hyperformula-tests repository step (using DEPLOY_TOKEN, target path test/hyperformula-tests).
    • Add a Fetch hyperformula-tests and sync branches step running test/fetch-tests.sh.
    • Name the existing main-repo checkout step for consistency with test.yml.

@sequba sequba self-assigned this May 11, 2026
@sequba sequba requested a review from marcin-kordas-hoc May 11, 2026 14:08
@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for hyperformula-docs ready!

Name Link
🔨 Latest commit c5dc295
🔍 Latest deploy log https://app.netlify.com/projects/hyperformula-docs/deploys/6a01e2f377f9410008bbfb2c
😎 Deploy Preview https://deploy-preview-1672--hyperformula-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (1b6767f) to head (c5dc295).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1672   +/-   ##
========================================
  Coverage    97.16%   97.16%           
========================================
  Files          175      175           
  Lines        15319    15319           
  Branches      3287     3287           
========================================
  Hits         14884    14884           
  Misses         435      435           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Performance comparison of head (c5dc295) vs base (1b6767f)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 516.87 | 490.36 | -5.13%
                                      Sheet B | 171.03 | 156.34 | -8.59%
                                      Sheet T | 143.49 | 137.03 | -4.50%
                                Column ranges | 533.53 | 522.16 | -2.13%
Sheet A:  change value, add/remove row/column |  16.57 |  16.36 | -1.27%
 Sheet B: change value, add/remove row/column | 143.64 | 141.83 | -1.26%
                   Column ranges - add column | 158.01 | 159.54 | +0.97%
                Column ranges - without batch | 483.51 | 493.34 | +2.03%
                        Column ranges - batch | 121.46 | 129.57 | +6.68%

@sequba sequba merged commit d213a57 into develop May 11, 2026
33 of 35 checks passed
@sequba sequba deleted the fix-lint-action-on-gh branch May 11, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant