[EXPERIMENT] HF-161 + lint fix combined CI check (do not merge)#1673
Closed
marcin-kordas-hoc wants to merge 5 commits into
Closed
[EXPERIMENT] HF-161 + lint fix combined CI check (do not merge)#1673marcin-kordas-hoc wants to merge 5 commits into
marcin-kordas-hoc wants to merge 5 commits into
Conversation
… to known-limitations)
Per Q2 principle (describe runtime-observable behavior, not internal strings): replace verbatim copies of internal parser error messages with behavioral descriptions. Future internal-string refactors will no longer silently invalidate these doc comments.
|
Task linked: HF-161 Document limitations of the OFFSET function |
✅ Deploy Preview for hyperformula-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyperformula-dev-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Performance comparison of head (3655a29) vs base (d213a57) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1673 +/- ##
========================================
Coverage 97.16% 97.16%
========================================
Files 175 175
Lines 15319 15319
Branches 3287 3287
========================================
Hits 14884 14884
Misses 435 435 🚀 New features to boost your workflow:
|
Collaborator
Author
|
PoC complete — hyperformula-tests#12 merged 2026-05-14, CI on #1666 now green (lint rerun ✓). This experiment proved the lint fix unblocks HF-161 end-to-end. Closing without merge; experimental branches in both repos will be deleted next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: PoC to verify that PR #1666 (HF-161 docs) passes CI once the tests-repo lint regression (handsontable/hyperformula-tests#12) is resolved.
This branch is identical to
feature/hf-161-offset-limitations(the HF-161 PR head), but its matching branch inhyperformula-testscarries the lint-fix from #12. The lint workflow'sfetch-tests.shchecks out the matching branch in tests-repo, so this PR exercises the full pipeline end-to-end.Composition
experimental/hf-161-with-lint-fix← identical tofeature/hf-161-offset-limitations(@4b5366c5d)experimental/hf-161-with-lint-fix← identical tofix/lint-errors-on-develop(@79a0630)Expected outcome
All CI checks green — same set that's currently green on #1666 (32 success, 3 neutral) plus lint job passing.
Cleanup
When the experiment concludes:
experimental/hf-161-with-lint-fixin both reposWhat this proves / does not prove