This repository was archived by the owner on Oct 2, 2026. It is now read-only.
Document the blockApproval config option - #387
Merged
Merged
Conversation
Adds a section for the option introduced in happo/happo#636. It is marked unreleased so it stays out of the production build until the next minor version of happo ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
happo v6.21.0 is out and the server side is deployed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
blockApprovalsection to the configuration page, covering the option introduced in happo/happo#636 and released in happo v6.21.0.What changed
## blockApprovalsection indocs/configuration.md, betweendeepCompareandfailOnWaitForTimeout. It has a config example, a table of the two conditions (renderErrorsandaccessibilityViolations), and a note that the conditions can be turned on in a single pull request.Testing
pnpm lintformatting check passes for the changed file.pnpm buildsucceeds and the built configuration page includes the section.🤖 Generated with Claude Code