Open
Conversation
aushev-dev
force-pushed
the
memory-optimization
branch
2 times, most recently
from
0e634d2 to
5448a93
Compare
aushev-dev
force-pushed
the
memory-optimization
branch
from
5448a93 to
96988a1
Compare
spajic
approved these changes
Feb 17, 2025
| - gem memory_profiler | ||
| - gem ruby-prof и отчеты callstack & qcachegrind | ||
| - gem stackprof + CLI и Speedscope | ||
| - второй thread для мониторинга памяти |
| cols = line.split(',') | ||
| ``` | ||
| - memory_profiler | ||
| - Вместо разделения строки на части с помощью split и проверки первого элемента, я решил использовать метод start_with? |
Collaborator
There was a problem hiding this comment.
👍 clever move; можно даже по первой букве определить тип строки
| ') | ||
| def work(file_path = 'data.txt', memory_watcher = false) | ||
| if memory_watcher | ||
| memory_watcher = MemoryWatcher.new(70) |
| users_objects = users_objects + [user_object] | ||
| ``` | ||
| - memory_profiler | ||
| - Вместо оператора + было применено использование метода <<, который добавляет элемент в существующий массив без создания нового объекта. |
Collaborator
There was a problem hiding this comment.
nice work, like что не стали сразу все << во всех местах в один шаг объединять
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.