Open
Conversation
Author
|
Честно сказать, в этом задании хотелось бы побольше времени поработать, найти больше точек оптимизации через APM и rack-mini-profiler. Возможно, позже еще доработаю. |
aushev-dev
force-pushed
the
optimization-task-4
branch
from
bd23a8e to
bf2153c
Compare
aushev-dev
force-pushed
the
optimization-task-4
branch
from
bf2153c to
c0ba589
Compare
spajic
reviewed
Mar 20, 2025
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
✅ 💪 всё чётко, спасибо за работу!
| <%= render "stories/sign_in_invitation" %> | ||
| <% end %> | ||
| <%= render "articles/single_story", story: story %> | ||
| <% cache ["v1", story, story.updated_at, story.comments_count, story.positive_reactions_count] do %> |
| Time per request: 149.877 [ms] (mean, across all concurrent requests) | ||
| Transfer rate: 857.59 [Kbytes/sec] received | ||
| ``` | ||
| - Время обработки всех запросов сократилось в 4 раза с 60 до 15 секунд. Также количество Failed сократилось с 99 до 0. |
Collaborator
There was a problem hiding this comment.
99 failed - там response size чуть не сходится; видимо есть какие-то отличия от исходного ответа, который берётся за эталон; а при local_production всё стабильно в этом плане
|
|
||
| ### 2. Отсутствие кеширования partial-ов _single_story.html.erb | ||
| - Readme задания и rack-mini-profiler | ||
| - Добавил кеширование partial'а, учел, что в него входят счётчики лайков и комментариев. |
| Time per request: 71.791 [ms] (mean, across all concurrent requests) | ||
| Transfer rate: 1772.19 [Kbytes/sec] received | ||
| ``` | ||
| - Время обработки всех запросов сократилось в два раза с 14 до 7 секунд. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.