Open
Conversation
spajic
approved these changes
Oct 3, 2021
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
👍 Очень здорово! Достойный результат и интересно, что на своём проекте ✅
| 1 1 0.0312s 0.0312s 0.0312s book_with_categories | ||
| ``` | ||
|
|
||
| ## Финишный прогон тестов, В БЮДЖЕТ УЛОЖИЛСЯ: |
Collaborator
There was a problem hiding this comment.
йеее!
В такой задаче как оптимизация тестов конечно трудно понять какой "бюджет" должен быть.
Круто, что вы решили сделать в 3 раза быстрее и получилось.
Можно ещё исходить из того, что зафиксировали текущее состоянии, "подпёрли его снизу" и решили, что вот наш бюджет, по крайней мере из него выходить не будем.
А в случае успешной оптимизации передвигать и подпорку.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see case-study.md