Repository navigation
Record steps through TraceRecorder, as upstream does - #424
Merged
Merged
Conversation
Recording lived inside ActionDispatcher, StepAccounting and Act. It now lives in Cache/TraceRecorder.cs, with DescribeTarget, and the recorder tests drive it directly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KWUdrjfarTEM4dmBbK6GaV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KWUdrjfarTEM4dmBbK6GaV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording lived inside the dispatcher, the step accounting and
Act. It now lives inTraceRecorder(Cache/TraceRecorder.cs), withDescribeTarget, and the recorder tests drive it directly with upstream names. Behavior does not change. .NET-only symbols:TraceRecorder.Actions,Clear,RecordScroll(the fold is live-only, because replay commits already-folded entries), and theRecord(kind, node, ...)overload. Partial ports (no summary, truncation flag, action cap, selector, or spans in the port): the descriptors, finalize, secret-fill, fold, gap, and node-verb tests, andDescribeTarget. Not ported: the model-identity, twin-poisoning, within-container, input-poisoning, span-folding, action-cap, drag/upload, and bare-point tests.Not ported upstream tests (follow-up): "omits an oversized recorded provider/model", "omits blank recording identity", "poisons a trace whose target is an unnamed twin...", "masks a secret resolved after capture in the container the node sat within", "poisons the trace instead of bending a replay input", "keeps the smallest coverage when folding scrolls...", "truncates past the action cap...", "rejects a stored check, upload, or drag that lost a field", "returns undefined for a node with nothing durable to say", and the four bare-point tap its.
Closes #383
🤖 Generated with Claude Code
https://claude.ai/code/session_01KWUdrjfarTEM4dmBbK6GaV