Repository navigation
Accept trace and video settings in the config - #434
Merged
Merged
Conversation
The config loader rejected trace and video. Upstream accepts them at the config root and on a target, with five recording modes. The port now reads them, resolves the mode as upstream does, and exposes it on the target, the fixture, and the session options. E2E_TRACE and E2E_VIDEO stand in for the --trace and --video flags. Nothing records yet. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KWUdrjfarTEM4dmBbK6GaV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config loader rejected
traceandvideo, so the recording modes upstream offers could not be set. The port now reads both keys at the config root and on the target, resolves the mode as upstream does, and exposes it onTargetConfig, the fixture, andE2ESessionOptions. Nothing records yet: this only carries the settings so video, debug, and AI trace work can start. The .NET-only names areE2E_TRACEandE2E_VIDEO(they stand in for--traceand--video) and theTraceandVideofixture and session properties. Partial tests, each noting that the flag is the variable: the mode override and unknown-mode tests inConfig/TraceTestsandConfig/VideoTests, the old-spelling test inArtifactsConfigTests, and the CI test inResolveConfigTests(no workers). Not ported: the config digest test, since the port has no digest.🤖 Generated with Claude Code
https://claude.ai/code/session_01KWUdrjfarTEM4dmBbK6GaV