Fix execute wait false timeouts and active HTTP session reaping#228
Draft
cursor[bot] wants to merge 4 commits into
Draft
Fix execute wait false timeouts and active HTTP session reaping#228cursor[bot] wants to merge 4 commits into
cursor[bot] wants to merge 4 commits into
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two high-severity execute-wait correctness issues:
harness_execute(..., wait=true)no longer reportsexecution_timed_out=truewhen polling gives up after five consecutiveexecution.geterrors before the configured timeout expires. It now fails the wait path so callers see_wait.errorwhile preserving the successful trigger response.Added focused regression coverage for both behaviors and recorded the inspection in
tasks/todo.md.Type of Change
Checklist
Validation:
pnpm test tests/utils/poll-execution.test.ts tests/integration/http-transport.test.tspnpm typecheckpnpm buildpnpm test(59 files / 1400 tests)