fix: preserve HTTPX response streams during instrumentation#15
Open
shreyas70 wants to merge 6 commits into
Open
fix: preserve HTTPX response streams during instrumentation#15shreyas70 wants to merge 6 commits into
shreyas70 wants to merge 6 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
These internal design/plan artifacts should not ship with the SDK change.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPX response hooks previously drained the transport response stream to capture its body, then replaced HTTPX's private `_httpcore_stream` state with replay data. That buffered streaming responses, depended on private internals, and could leave streams partially consumed when capture failed.
This change removes that unsafe response-stream consumption and private mutation for all synchronous and asynchronous HTTPX responses.
Behavior change
This removes unsafe stream handling implicated by instrumentation. It does not, by itself, prove the production gzip issue's complete causality.
Verification
Database integration tests were excluded because they require the repository's Docker services.
Made with Cursor