fix(web): render grounded-chat answers as markdown#33
Merged
Conversation
The Memory chat (and run AI summary) rendered the model's markdown answer as plain text: splitAiParagraphs collapsed single newlines into spaces — flattening bullet lists into one run-on paragraph — and never parsed markdown, so **bold** showed literal asterisks. Empty sections also rendered an ugly "No items found." card. - Route answer text + each key point through ReactMarkdown + remark-gfm (already deps): bold, nested bullets, ordered lists, inline code, links, tables. Normalize escaped \n first. - AiResultData now drops empty fields, so empty KEY POINTS is hidden instead of showing "No items found.". Remove dead splitAiParagraphs. - Add compact, on-brand markdown CSS scoped to .aiTextAnswer/.aiAnswerList (olive markers, weighted strong, tinted inline code, code blocks, tables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Memory grounded-chat panel (and the run AI-summary) rendered the model's markdown answer as plain text:
splitAiParagraphscollapsed every single newline into a space, flattening bullet lists into one run-on paragraph.**bold**showed literal asterisks.KEY POINTS · No items found.card.Fix
MarkdownTexthelper routes the answer + each key point throughReactMarkdown+remark-gfm(already dependencies, used for docs): bold, nested bullets, ordered lists, inline code, links, GFM tables. Escaped\nnormalized first.AiResultDatanow drops empty fields → empty KEY POINTS is hidden instead of "No items found." Removed the deadsplitAiParagraphs..aiTextAnswer/.aiAnswerList(olive::marker, weighted<strong>, green-tinted inlinecode, dark code blocks, bordered tables, nested-list indentation).Improves all three answer surfaces consistently: grounded chat panel, playground chat, and run AI summary.
Verification
tsctypecheck clean;vite buildclean (CSS +2.5KB; JS unchanged — markdown lib was already bundled).demo:deepbook: answer body renders 10 real<strong>spans, 1 top-level list + 4 nested sub-lists, 0 literal**; KEY POINTS = real bulleted list; no "No items found."