오늘의문장 조회 목업API 작성 및 Subject, Question 관련 Entity 작성#63
Open
오늘의문장 조회 목업API 작성 및 Subject, Question 관련 Entity 작성#63
Conversation
jakalroni
commented
Jan 28, 2023
jakalroni
commented
Jan 28, 2023
be/src/main/java/com/example/be/core/domain/question/QuestionSubject.java
Show resolved
Hide resolved
jakalroni
commented
Jan 28, 2023
nathan29849
requested changes
Jan 28, 2023
Contributor
nathan29849
left a comment
nathan29849
left a comment
There was a problem hiding this comment.
고생 많으셨습니다!
다른 코드들을 참고해서 테스트까지 작성해주신 부분 너무 좋았어요
PR 관련해서 질문 드릴 내용은 아래 comment로 남겨놓았으니 확인 부탁드릴게요~
be/src/main/java/com/example/be/core/domain/question/QuestionSubject.java
Show resolved
Hide resolved
be/src/test/java/com/example/be/core/web/question/InitQuestionControllerTest.java
Show resolved
Hide resolved
be/src/test/java/com/example/be/core/web/question/QuestionControllerFindTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗️ 이슈 번호
Closes #45
📝 구현 내용