-
Notifications
You must be signed in to change notification settings - Fork 22
Auto migrate hashicorp to ibm #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+665
−3
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
878c962
Add automatic HashiCorp to IBM copyright holder migration
CreatorHead c653017
Display files being updated regardless of verbose flag
CreatorHead fb48eed
Fix golangci-lint issues
CreatorHead 11c3b63
Fix --plan flag to show copyright holder updates and update config
CreatorHead 19c688d
Fix remaining golangci-lint errcheck issue
CreatorHead 0a3f20d
Fix 'is a directory' error in copyright holder migration
CreatorHead 5f7df3f
Add comprehensive test cases for directory skipping bug fix
CreatorHead da481e5
Fix golangci-lint errcheck issue in test
CreatorHead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this is only getting triggered in this branch/PR but when I run
copywrite headersagainst a repository with a directory in it - perhaps a directory name of a specific pattern - it fails here with the following error:https://github.com/hashicorp/hc-install
It puzzles me why does a directory even get this far past
copywrite/addlicense/main.go
Lines 280 to 282 in 0be59e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this:
Solution: Added
isDirectory()helper usingos.Stat()(follows symlinks) in both migration functions. Now directories are skipped gracefully instead of crashing.Commit:
0a3f20d- please test with the updated branch.