fix(status): always consider operation generate diagnostics when determining exit status#174
Merged
Conversation
…rmining exit status Currently our system for determining an overall status for an operation has to consider the status of each child operation. We missed the "generate" child operation for check, launch, run, and destroy. This fixes that so we always exit 1 if generate fails regardless of the desired operation. We also bump our dependencies as we intend to release this fix immediately. Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
added
the
changelog/bug
hashigator
approved these changes
Jun 8, 2026
hashigator
left a comment
hashigator
left a comment
There was a problem hiding this comment.
LGTM - Clean fix for missing generate diagnostics in exit status determination.
Core Fix ✅
- Added generate diagnostics checks for check/launch/run/destroy operations
- Simple 4-line addition to
resDiags()function
Test Coverage ✅
- Comprehensive tests for all affected operations
- New invalid scenario with missing module
- Tests verify proper error handling and exit codes
Minor Note
Test code is duplicated across 5 files (~65 lines each) but follows existing test patterns in the codebase.
Signed-off-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our system for determining an overall status for an operation has to consider the status of each child operation. We missed the "generate" child operation for check, launch, run, and destroy. This fixes that so we always exit 1 if generate fails regardless of the desired operation.
We also bump our dependencies as we intend to release this fix immediately.
How to read this pull request
You may provide an optional explanation of the best way a review might
approach the changes that are being proposed in this pull request.
Checklist